URL: https://github.com/SSSD/sssd/pull/5526 Author: alexey-tikhonov Title: #5526: Covscan fixes Action: opened
PR body: """ This is overtake of PR #5498 (based on https://github.com/SSSD/sssd/pull/5498#issuecomment-789576996 comment)
Two patches were taken "as is". Patch "symlink() expects non-NULL second argument" was slightly amended (different error code used). One patch was skipped as I either don't understand it or it's not entirely correct. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5526/head:pr5526 git checkout pr5526
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
alexey-tikhonov commented: """ Those patches were already reviewed by me, but I'm not sure if I can set ACK as I changed one patch a little bit. Second look won't hurt anyway.
covscan: https://cov01.lab.eng.brq.redhat.com/covscanhub/task/208327/log/fixed.err (sorry for internal link) """
See the full comment at https://github.com/SSSD/sssd/pull/5526#issuecomment-789798264
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
pbrezina commented: """ Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/5526#issuecomment-791358895
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5526
* `master` * 42c9ca0cdbb0508812dc1c17382d277fa1f83e8a - covscan: symlink() expects non-NULL second argument * d73f1282748201582006185312701b4b09460195 - covscan: initialize ret variable before use * 32d2aa55435ea461fc425e776c12b8c5cffd8e09 - prompt config: fix covscan errors
"""
See the full comment at https://github.com/SSSD/sssd/pull/5526#issuecomment-791359548
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5526 Title: #5526: Covscan fixes
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5526 Author: alexey-tikhonov Title: #5526: Covscan fixes Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5526/head:pr5526 git checkout pr5526
sssd-devel@lists.fedorahosted.org