Hello,
I noticed a small discrepancy, so I fixed it. There was duplication of mock function in our tests.
Simple patch is attached.
Regards
On (04/05/16 11:55), Petr Cech wrote:
Hello,
I noticed a small discrepancy, so I fixed it. There was duplication of mock function in our tests.
Simple patch is attached.
Regards
-- Petr^4 Čech
From 1d678d30330d326c75b6b6ac5fe0d8b652804e0e Mon Sep 17 00:00:00 2001 From: Petr Cech pcech@redhat.com Date: Wed, 4 May 2016 05:44:35 -0400 Subject: [PATCH] TEST: Removing duplication of mock_rctx
There were duplicaton of mock_rctx().
It isn't related to this ticket :-) and it does not solve it.
I will remove it before pushing the patch
CI passed http://sssd-ci.duckdns.org/logs/job/42/85/summary.html
ACK
LS
On 05/05/2016 10:39 AM, Lukas Slebodnik wrote:
It isn't related to this ticket :-) and it does not solve it.
I will remove it before pushing the patch
CI passed http://sssd-ci.duckdns.org/logs/job/42/85/summary.html
ACK
LS
Hi Lukas,
thank you for review.
You're right, it is not connected. So... is it right to send patches without tickets? Or is it necessary file the ticket for such little things?
Regards
On 05/05/2016 10:44 AM, Petr Cech wrote:
On 05/05/2016 10:39 AM, Lukas Slebodnik wrote:
It isn't related to this ticket :-) and it does not solve it.
I will remove it before pushing the patch
CI passed http://sssd-ci.duckdns.org/logs/job/42/85/summary.html
ACK
LS
Hi Lukas,
thank you for review.
You're right, it is not connected. So... is it right to send patches without tickets?
Yes.
Or is it necessary file the ticket for such little things?
No.
Regards
On (05/05/16 10:44), Petr Cech wrote:
On 05/05/2016 10:39 AM, Lukas Slebodnik wrote:
It isn't related to this ticket :-) and it does not solve it.
I will remove it before pushing the patch
CI passed http://sssd-ci.duckdns.org/logs/job/42/85/summary.html
ACK
LS
Hi Lukas,
thank you for review.
You're right, it is not connected. So... is it right to send patches without tickets? Or is it necessary file the ticket for such little things?
We needn't have a ticket for such small issue. Ticket would make sense only if it is a bug and might affect older/stable versions.
pushed to master * 9face844e3063b61ab19e1d82bbf3d9f9de76ac7
LS
sssd-devel@lists.fedorahosted.org
-
Lukas Slebodnik -
Pavel Březina -
Petr Cech