Looking at #356 I realized timer events were improperly handled in dp. Timer events are always freed as soon as the handler returns. Freeing them within the handler is actually a bug.
The following patch changes the way they are handled and this should also fix the segfault in #356 as well as other that I expect to happen when a timeout actually happens.
I have compiled but not yet tested the code, but I am confident the fix is right.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/05/2010 09:04 AM, Simo Sorce wrote:
Looking at #356 I realized timer events were improperly handled in dp. Timer events are always freed as soon as the handler returns. Freeing them within the handler is actually a bug.
The following patch changes the way they are handled and this should also fix the segfault in #356 as well as other that I expect to happen when a timeout actually happens.
I have compiled but not yet tested the code, but I am confident the fix is right.
Simo.
Ack. (Tested as well)
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 01/05/2010 09:59 AM, Stephen Gallagher wrote:
On 01/05/2010 09:04 AM, Simo Sorce wrote:
Looking at #356 I realized timer events were improperly handled in dp. Timer events are always freed as soon as the handler returns. Freeing them within the handler is actually a bug.
The following patch changes the way they are handled and this should also fix the segfault in #356 as well as other that I expect to happen when a timeout actually happens.
I have compiled but not yet tested the code, but I am confident the fix is right.
Simo.
Ack. (Tested as well)
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Simo Sorce -
Stephen Gallagher