DEBUG macro refactoring
by Nikolai Kondrashov
Hi everyone,
I've been looking at the sssd sources for some test failure investigation and
noticed that the DEBUG macro expands to quite a lot of code. I decided to see
if it can be reduced and what the impact will be. The result is the patches
that follow.
I've noticed that the total size of installed binaries produced by the
standard Fedora build with "reconfig && chmake" drops by 20% after applying
these patches.
A build on Debian, configured similarly to the one used in the Debian package
dropped by 44%.
I've verified that all the patches build and pass the tests run by "chmake",
but otherwise haven't tested them.
Sincerely,
Nick
10 years, 4 months
[PATCH] AD: Always refresh LDAP subdomain list
by Jakub Hrozek
Hi,
I found this bug when testing the GC patches. Previously, when SSSD was
started, but subdomains list was up-to-date, the ad_ctx was not
initialized for the subdomain.
I was also thinking whether we should re-initialize the domain-realm
mappings after sssd startup, the way we re-initialize kdcinfo files. I
don't think it's strictly necessary because if someone deletes a file in
/var/lib/sss/pubconf, he should keep the broken pieces, but perhaps we
should be at least aware..
10 years, 4 months
home directory issue; oddjob_mkhomedir issue
by Yassir Elley
Hi guys,
I am getting the following two warnings running with the latest F20 sssd bits:
[yelley@f20-laptop ~]$ ssh allowed_user@FOO.COM(a)localhost
allowed_user@FOO.COM(a)localhost's password:
org.freedesktop.DBus.Error.ServiceUnknown: The name com.redhat.oddjob_mkhomedir was not provided by any .service files
Could not chdir to home directory /home/foo.com/allowed_user: No such file or directory
Any ideas?
Regards,
Yassir.
10 years, 4 months
AUTOTOOLS: krb5 1.12 is also supported krb5 libs
by Lukas Slebodnik
ehlo,
krb5-1.12-beta2 was released few days ago.
pac responder was not properly detected with krb5 1.12 library,
because it was not recognized as supported.
The simple patch is attached.
LS
10 years, 4 months
[PATCH 6/7] Properly align buffer when storing pointers.
by Michal Židek
On 11/14/2013 01:14 PM, Lukas Slebodnik wrote:>>From
45336d3596b8d93ebf866c727c566169c404b60c Mon Sep 17 00:00:00 2001
>> >From: Michal Zidek<mzidek(a)redhat.com>
>> >Date: Tue, 10 Sep 2013 23:09:04 +0200
>> >Subject: [PATCH 6/7] Properly align buffer when storing pointers.
>> >
>> >Properly align buffer address to sizeof(char *) when storing
>> >pointers to string and disable alignment warnings with #pragma.
>> >
>> >resolves:
>> >https://fedorahosted.org/sssd/ticket/1359
>> >---
>> >src/sss_client/nss_group.c | 5 +++--
>> >src/sss_client/nss_mc_group.c | 3 +++
>> >src/sss_client/nss_services.c | 4 ++--
>> >3 files changed, 8 insertions(+), 4 deletions(-)
>> >
>> >diff --git a/src/sss_client/nss_group.c b/src/sss_client/nss_group.c
>> >index a7fb093..68e14d3 100644
>> >--- a/src/sss_client/nss_group.c
>> >+++ b/src/sss_client/nss_group.c
>> >@@ -233,14 +233,15 @@ static int sss_nss_getgr_readrep(struct
sss_nss_gr_rep *pr,
>> > NULL);
>> > if (ret != EOK) return ret;
>> >
>> >- /* Make sure pr->buffer[i+pad] is 32 bit aligned */
>> >+ /* Make sure pr->buffer[i+pad] is aligned to sizeof(char *) */
>> > pad = 0;
>> >- while((i + pad) % 4) {
>> >+ while((i + pad) % sizeof(char *)) {
> I am not sure about this. There was comment;
> "Make sure pr->buffer[i+pad] is 32 bit aligned"
>
> And you changed alignment to 64-bits on x86_64 and to 32-bits on i386
> platform.
> This is a client code, so some more experienced should tell what
> is the right solution.
>
Aligning the address to 4 bytes and then using it as the beginning of
array of pointers is simply wrong and should be fixed. So I think it was
a mistake in both the code and the comment (maybe one led to the other).
But is is possible that I am reading the code wrong.
Michal
10 years, 4 months
[PATCH] NSS: Fix memory leak in sss_setnetgrent
by Lukas Slebodnik
ehlo,
struct nss_cmd_ctx was not released in function nss_cmd_setnetgrent_done
and it wasn't used in the other function, because getnetgrent creates its
own nss_cmd_ctx context. struct nss_cmd_ctx was released after closing client
because it was allocated under client context. Memory leak is apparent with
long living clients.
Simple patch is attached.
LS
10 years, 4 months
