URL: https://github.com/SSSD/sssd/pull/94 Title: #94: Enable {socket,dbus}-activation for responders
jhrozek commented: """ On Fri, Jan 13, 2017 at 02:52:49AM -0800, fidencio wrote:
On Fri, Jan 13, 2017 at 11:42 AM, Jakub Hrozek notifications@github.com wrote:
*@jhrozek* commented on this pull request.
In src/util/util.c https://github.com/SSSD/sssd/pull/94#pullrequestreview-16544855:
@@ -1277,3 +1279,12 @@ bool is_user_or_group_name(const char *sudo_user_value)
/* Now it's either a username or a groupname */ return true;
}
+bool is_socket_activated(void) +{ +#ifdef HAVE_SYSTEMD
- return !!socket_activated;
Why the double negative here? is it converting int to bool?
That's exactly the case. I may be mistaken in the way I implemented it, but the value get from the command line i stored as an int and on this function I'm just return true/flase indicating wthether the service was socket-activated.
I'm not sure if I can just store the command line option as a bool, but I've seen it's not done with other bool command options (as debug-to-files, per example).
No, it looks like popt still only supports int. So this is probably OK, although I would personally use the tri-state operator, but meh :)
"""
See the full comment at https://github.com/SSSD/sssd/pull/94#issuecomment-272498301