URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: opened
PR body: """ There is race condition when dynamic libraries are unloaded. Talloc library calls our destructors but they still need openssl calls which might be not available.
Solution is to free explicitely memory context and trigger destructors before calling exit().
The first commit seems to fix the issue but consider similar way of freeing resources in kerberos and ldap providers in other two commits.
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1672584
"""
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
sumit-bose commented: """ Hi,
in general I agree with the patches, see my minor comments in-line.
There are typos in the commit messages 'condirion' and 'explicitely'.
Do I understand it correctly that you do not have a reproducer except the regression tests mentioned in the Bugzilla ticket? In this case I'd like to do some additional tests to see if I can find an independent reproducer.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-498328380
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
thalman commented: """ Sumit, thanks for review,
I updated commits as well as commit messages. And you are right, I have no reproducer. This bug appears in CI, but not always.
Tom """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-498671662
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
thalman commented: """ Thanks @pbrezina for this suggestion. It's much more elegant this way.
"""
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-523871414
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
pbrezina commented: """ Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-524235792
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
sumit-bose commented: """ Master: - f19f8e6b917e77d5d2bfdedc78e5669b522ea265 """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-524364132
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: reopened
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
sumit-bose commented: """ Hi @thalman,
I'm sorry, but I had to revert the commit of the pull request because there is some oddness in the latest version. The static `be_process_finalize()` and `be_process_install_sigterm_handler` are defined in `src/providers/data_provider_be.c` but nowhere used.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-524440217
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: -Pushed
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
thalman commented: """
I'm sorry, but I had to revert the commit of the pull request because there is some oddness in the latest version. The static `be_process_finalize()` and `be_process_install_sigterm_handler` are defined in `src/providers/data_provider_be.c` but nowhere used.
bye, Sumit
Thank you for spotting this issue. I broke the code during rebase.
Please see fixed version.
Tom """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-524773026
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
pbrezina commented: """ I'm sorry for missing that. `SIGTERM` handler is installed in the new patch and `be_process_finalize` is called upon termination. """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-525708037
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
pbrezina commented: """ Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-525708121
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
sumit-bose commented: """ Master: - a9669683de3a1c39dc4e47dd2aca0a9f99b652a9 """
See the full comment at https://github.com/SSSD/sssd/pull/821#issuecomment-526214486
URL: https://github.com/SSSD/sssd/pull/821 Author: thalman Title: #821: SERVER: Receving SIGSEGV process on shutdown Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/821/head:pr821 git checkout pr821
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/821 Title: #821: SERVER: Receving SIGSEGV process on shutdown
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
pbrezina -
sumit-bose
-
thalman