1:14 a.m.
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
2 a.m.
New subject: [sssd PR#5410][synchronized] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
2:10 a.m.
New subject: [sssd PR#5410][synchronized] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
2:10 a.m.
New subject: [sssd PR#5410][+Waiting for review] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
Label: +Waiting for review
3:50 a.m.
New subject: [sssd PR#5410][comment] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
sgoveas commented:
"""
Please resolve pep8 issue
https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-5410/2/rhel8/ci-pep8.log
To get more information, you can click on 'Details' against the test suite that
failed.
Add clear summary message for the PR, you can provide more details, like the bug or ticket
this code with test in the description section
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732049132
3:50 a.m.
New subject: [sssd PR#5410][-Waiting for review] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
Label: -Waiting for review
3:50 a.m.
New subject: [sssd PR#5410][+Changes requested] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
Label: +Changes requested
4:04 a.m.
New subject: [sssd PR#5410][comment] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
ikerexxe commented:
"""
I think that you should also clone bugzilla ticket to github ticket and use the last one
on the commit message. If you don't know how to do clone the ticket ping me on IRC
(@ipedrosa). Moreover, commit message is not very clear, can you improve it following the
template?
```
COMPONENT: Subject
Explanation
Resolves: https://github.com/SSSD/sssd/issues/XXXX
```
Finally, I think that you could squash all commits into one.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732057070
4:13 a.m.
New subject: [sssd PR#5410][comment] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
alexey-tikhonov commented:
"""
I think that you should also clone bugzilla ticket to github ticket
and use the last one on the commit message
...
Resolves: https://github.com/SSSD/sssd/issues/XXXX
This is test automation, this patch itself doesn't resolve the issue. So I'm not
sure if it's correct to state "resolves" here.
Moreover, usually BZ is already cloned to the upstream to the moment test is done (in this
case this is #5295)
But I agree we should link those somehow.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732062219
9:26 a.m.
New subject: [sssd PR#5410][comment] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Bz1734040
ikerexxe commented:
"""
> I think that you should also clone bugzilla ticket to github
ticket and use the last one on the commit message
> ...
> Resolves: https://github.com/SSSD/sssd/issues/XXXX
This is test automation, this patch itself doesn't resolve the issue. So I'm not
sure if it's correct to state "resolves" here.
Definitely `Resolves` is not the correct keyword here but there should be some link. Maybe
`Test` or `Check` are better words.
Moreover, usually BZ is already cloned to the upstream to the moment test is done (in
this case this is #5295)
Thanks for pointing the upstream ticket.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-732231499
4:58 a.m.
New subject: [sssd PR#5410][synchronized] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
7:53 a.m.
New subject: [sssd PR#5410][synchronized] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
8:17 a.m.
New subject: [sssd PR#5410][synchronized] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
3:19 a.m.
New subject: [sssd PR#5410][synchronized] Bz1734040
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Bz1734040
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
4:38 a.m.
New subject: [sssd PR#5410][edited] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: edited
Changed field: title
Original value:
"""
Bz1734040
"""
4:45 a.m.
New subject: [sssd PR#5410][edited] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: edited
Changed field: body
Original value:
"""
"""
4:46 a.m.
New subject: [sssd PR#5410][+Waiting for review] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Waiting for review
4:46 a.m.
New subject: [sssd PR#5410][-Waiting for review] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Waiting for review
5:06 a.m.
New subject: [sssd PR#5410][synchronized] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
5:08 a.m.
New subject: [sssd PR#5410][edited] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: edited
Changed field: body
Original value:
"""
Configures the AD domain and makes it unreachable by changing
ad_domain parameter. Checks the request flag 0x0001 in log after sssd restart.
"""
5:08 a.m.
New subject: [sssd PR#5410][+Waiting for review] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Waiting for review
5:09 a.m.
New subject: [sssd PR#5410][-Changes requested] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Changes requested
4:43 a.m.
New subject: [sssd PR#5410][synchronized] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
6 a.m.
New subject: [sssd PR#5410][synchronized] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
6:03 a.m.
New subject: [sssd PR#5410][comment] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
sgoveas commented:
"""
Looks good to me
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-736509208
6:03 a.m.
New subject: [sssd PR#5410][-Waiting for review] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Waiting for review
6:03 a.m.
New subject: [sssd PR#5410][+Accepted] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Accepted
6:44 a.m.
New subject: [sssd PR#5410][comment] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
ikerexxe commented:
"""
Let's wait for CI results but it also looks good to me.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-736529136
5:01 a.m.
New subject: [sssd PR#5410][+Ready to push] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Ready to push
5:03 a.m.
New subject: [sssd PR#5410][comment] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5410
* `master`
* 78ef0828dd745cbc55fc03cc42bd7ef26e70785e - Test: AD: For sssd crash in
ad_get_account_domain_search
"""
See the full comment at https://github.com/SSSD/sssd/pull/5410#issuecomment-738720877
5:03 a.m.
New subject: [sssd PR#5410][+Pushed] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: +Pushed
5:03 a.m.
New subject: [sssd PR#5410][-Accepted] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Accepted
5:03 a.m.
New subject: [sssd PR#5410][-Ready to push] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Label: -Ready to push
5:03 a.m.
New subject: [sssd PR#5410][closed] Test: AD: For crash in ad_get_account_domain_search
URL: https://github.com/SSSD/sssd/pull/5410
Author: madhuriupadhye
Title: #5410: Test: AD: For crash in ad_get_account_domain_search
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5410/head:pr5410
git checkout pr5410
1252
days inactive
1267
days old
sssd-devel@lists.fedorahosted.org
33 comments
5 participants
participants (5)
-
alexey-tikhonov -
ikerexxe
-
madhuriupadhye
-
pbrezina
-
sgoveas