On Wed, Aug 21, 2019 at 02:00:40PM -0700, Richard Sharpe wrote: > Hi folks, > > In the current code downloaded from github I see the following function: > > src/sss_client/nfs/sss_nfs_client.c:sss_nfs_uid_to_name: > > static int sss_nfs_uid_to_name(uid_t uid, char *domain, char *name, size_t len) > { > int rc; > > if (name == NULL) { > IDMAP_LOG(0, ("%s: name is null", __func__)); > return -EINVAL; > } > > rc = get_user_from_mc(name, len, uid); > if (rc != 0) { > rc = id_to_name(name, len, uid, SSS_NSS_GETPWUID); > } > > log_actual_rc(__func__, rc); > rc = normalise_rc(rc); > > return -rc; > } > > The code does nothing with the domain parameter, however, the > interface requirement is that if an unqualified name is to be > returned, perhaps from /etc/passwd, if domain is non null, it should > be appended to the name to be returned preceded by an '@'. > > Eg, administrators@localhost. > > The same goes for sss_nfs_gid_to_name. > > See, for example, nfs-utils:support/nfsidmap/nss.c:nss_uid_to_name > which calls write_name to handle appending the local domain name > passed in if one is not present. > > Have I missed something here? Hi Richard, thanks for the report I guess we simply assumed that SSSD is configured to always return fully-qualified names and forgot other other cases. Would you mind to open a ticket on https://bugzilla.redhat.com or https://pagure.io/SSSD/sssd/new_issue?