11:44 a.m.
URL: https://github.com/SSSD/sssd/pull/63
Author: sorah
Title: #63: BUILD: Fix installation without samba
Action: opened
PR body:
"""
winbindplugindir is defined only when BUILD_SAMBA is on. Also the file
doesn't exist when BUILD_SAMBA is off, so installation will fail.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/63/head:pr63
git checkout pr63
11:45 a.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255539356
11:45 a.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255539359
12:05 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
fidencio commented:
"""
Patch makes sense.
I'll run our CI on this and ACK as soon as CI passes.
Thanks for you contribution.
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255540537
2:05 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
lslebodn commented:
"""
ok to test
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255547516
3:58 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
lslebodn commented:
"""
On (22/10/16 10:05), fidencio wrote:
Patch makes sense.
I'll run our CI on this and ACK as soon as CI passes.
Our CI would not catch such use-case.
But I verfied it with following steps:
```
./configure --without-samba
make -j8 check
make install DESTDIR=$PWD/_inst
```
`make check` still fails but that's solved in different
PR https://github.com/SSSD/sssd/pull/56
ACK++
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255553612
3:59 p.m.
New subject: [sssd PR#63][+Pushed] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
Label: +Pushed
3:59 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
lslebodn commented:
"""
master:
* 13adcd07000ba3ca1422c6ee863df17d70e2b14c
sssd-1-14:
* 1fb3cccd83ede1bbe99319254c88fce1285b352d
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255553674
3:59 p.m.
New subject: [sssd PR#63][closed] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Author: sorah
Title: #63: BUILD: Fix installation without samba
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/63/head:pr63
git checkout pr63
6:06 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
sorah commented:
"""
Thanks!
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-255559349
1:15 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
lslebodn commented:
"""
On (22/10/16 10:05), fidencio wrote:
Patch makes sense.
I'll run our CI on this and ACK as soon as CI passes.
Our CI would not catch such use-case.
But I verfied it with following steps:
```
./configure --without-samba
make -j8 check
make install DESTDIR=$PWD/_inst
```
`make check` still fails but that's solved in different
PR https://github.com/SSSD/sssd/pull/56
ACK++
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-256117695
1:24 p.m.
New subject: [sssd PR#63][comment] BUILD: Fix installation without samba
URL: https://github.com/SSSD/sssd/pull/63
Title: #63: BUILD: Fix installation without samba
lslebodn commented:
"""
ok to test
"""
See the full comment at https://github.com/SSSD/sssd/pull/63#issuecomment-256124715
2775
days inactive
2778
days old
sssd-devel@lists.fedorahosted.org
11 comments
1 participants
participants (1)
-
fidencio