URL: https://github.com/SSSD/sssd/pull/80 Author: celestian Title: #80: SYSDB: Sudorule without a sudoUser returns EINVAL Action: opened
PR body: """ This patch solved a regression caused by the recent patches to lowercase sudoUser -- in case sudoUser is missing completely, we abort the processing of this rule and all others.
With this patch, we return EINVAL and gracefully skip the malgormed rule instead.
Resolves: https://fedorahosted.org/sssd/ticket/3241 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/80/head:pr80 git checkout pr80
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Sudorule without a sudoUser returns EINVAL
jhrozek commented: """ This would work, but wouldn't it be better to return a custom error code instead of EINVAL so that we are sure we are not skipping some error from ldb or somewhere else? """
See the full comment at https://github.com/SSSD/sssd/pull/80#issuecomment-261256307
URL: https://github.com/SSSD/sssd/pull/80 Author: celestian Title: #80: SYSDB: Sudorule without a sudoUser returns EINVAL Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/80/head:pr80 git checkout pr80
URL: https://github.com/SSSD/sssd/pull/80 Author: celestian Title: #80: SYSDB: Sudorule without a sudoUser returns EINVAL Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/80/head:pr80 git checkout pr80
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Sudorule without a sudoUser returns EINVAL
celestian commented: """ New version pushed. """
See the full comment at https://github.com/SSSD/sssd/pull/80#issuecomment-261919172
URL: https://github.com/SSSD/sssd/pull/80 Author: celestian Title: #80: SYSDB: Fixing of sudorule without a sudoUser Action: edited
Changed field: title Original value: """ SYSDB: Sudorule without a sudoUser returns EINVAL """
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser
jhrozek commented: """ ACK, the rule without a sudoUser attribute is properly skipped and the other rules are normally stored. """
See the full comment at https://github.com/SSSD/sssd/pull/80#issuecomment-262215923
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser
jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/57/23/summary.html
the rawhide failure is not related, it's a know bug in the latest python-urllib release. """
See the full comment at https://github.com/SSSD/sssd/pull/80#issuecomment-262231558
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/80 Title: #80: SYSDB: Fixing of sudorule without a sudoUser
lslebodn commented: """ master: * 7e23edbaa7a6bbd0b461d5792535896b6a77928b
sssd-1-14: * 54f176066dafafdc12f6e0dd112ff6339308aa7c
"""
See the full comment at https://github.com/SSSD/sssd/pull/80#issuecomment-262499125
URL: https://github.com/SSSD/sssd/pull/80 Author: celestian Title: #80: SYSDB: Fixing of sudorule without a sudoUser Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/80/head:pr80 git checkout pr80
sssd-devel@lists.fedorahosted.org
-
fidencio