URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: opened
PR body: """ This series may conflict with PR53[0]. So either one or another will need to be rebased after the first one gets merged.
[0]: https://github.com/SSSD/sssd/pull/53 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
fidencio commented: """ Thanks for catching this, @lslebodn. I've ran the CI locally and it has passed. I was wondering what was my mistake and `git stash pop` gave me the answer.
Patches have been updated. """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-259200019
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
fidencio commented: """ Patches rebased on top of git master ... """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-259823179
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
jhrozek commented: """ Apart from the nitpick, I don't have any other comments. Unless someone else has, I can even squash the nitpick and just push the patches, -- just let me know. """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-262539383
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
fidencio commented: """ New version pushed.
``` [ffidenci@cat x86_64]$ git diff diff --git a/src/responder/secrets/local.c b/src/responder/secrets/local.c index a9cf74d..ed70193 100644 --- a/src/responder/secrets/local.c +++ b/src/responder/secrets/local.c @@ -461,8 +461,10 @@ static int local_check_max_payload_size(struct local_context *lctx, DEBUG(SSSDBG_OP_FAILURE, "Secrets' payload size [%d kb (%d)] exceeds the maximum allowed " "payload size [%d kb (%d)]\n", - payload_size * 1024 /* kb */, payload_size, - lctx->max_payload_size /* kb */, max_payload_size); + payload_size * 1024, /* kb */ + payload_size, + lctx->max_payload_size, /* kb */ + max_payload_size);
return ERR_SEC_PAYLOAD_SIZE_IS_TOO_LARGE; } ``` """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-262541883
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
jhrozek commented: """ ACK, I'll push when CI finishes """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-262710494
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
jhrozek commented: """ CI: http://sssd-ci.duckdns.org/logs/job/57/36/summary.html
the failure on rawhide is unrelated. """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-262722314
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
jhrozek commented: """ master: 9ba53ac52b12e2b9fdd3981d28ae56a8fece0131 7171a7584dda534dde5409f3e7f4657e845ece15 """
See the full comment at https://github.com/SSSD/sssd/pull/75#issuecomment-262723330
URL: https://github.com/SSSD/sssd/pull/75 Author: fidencio Title: #75: Add configuirable max payload size limit of a secret Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/75/head:pr75 git checkout pr75
URL: https://github.com/SSSD/sssd/pull/75 Title: #75: Add configuirable max payload size limit of a secret
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio