URL: https://github.com/SSSD/sssd/pull/77 Author: jhrozek Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0 Action: opened
PR body: """ None """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/77/head:pr77 git checkout pr77
URL: https://github.com/SSSD/sssd/pull/77 Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0
lslebodn commented: """ There are few pep8 issues ``` diff --git a/src/tests/intg/test_ldap.py b/src/tests/intg/test_ldap.py index 667ae27..bf25d95 100644 --- a/src/tests/intg/test_ldap.py +++ b/src/tests/intg/test_ldap.py @@ -952,6 +952,7 @@ def test_remove_user_from_nested_group(ldap_conn, ent.assert_group_by_name("group3", dict(mem=ent.contains_only()))
+ def zero_nesting_sssd_conf(ldap_conn, schema): """Format an SSSD configuration with group nesting disabled""" return \ @@ -961,6 +962,7 @@ def zero_nesting_sssd_conf(ldap_conn, schema): ldap_group_nesting_level = 0 """).format(INTERACTIVE_TIMEOUT)
+ @pytest.fixture def rfc2307bis_no_nesting(request, ldap_conn): ent_list = ldap_ent.List(ldap_conn.ds_inst.base_dn) @@ -974,6 +976,7 @@ def rfc2307bis_no_nesting(request, ldap_conn): create_sssd_fixture(request) return None
+ def test_zero_nesting_level(ldap_conn, rfc2307bis_no_nesting): ent.assert_group_by_name("group1", dict(mem=ent.contains_only("user1"))) ```
I will fix them before pushing patches.
Thank you very much for integration test. BTW downstream tests did not find any regressions.
ACK
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/77#issuecomment-260951073
URL: https://github.com/SSSD/sssd/pull/77 Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0
lslebodn commented: """ master: * 65e791f844b4513ca2c3ee23f8cd2979566b3719 * 538a7f1dd8339b90e0cfc64e7919a34d1d5c10d3
sssd-1-14: * a7be684411aff42e03e181dd81de921185e16c34 * e0b544e6f664c2ce5ddd8df866d996607ce488cc
"""
See the full comment at https://github.com/SSSD/sssd/pull/77#issuecomment-260959317
URL: https://github.com/SSSD/sssd/pull/77 Author: jhrozek Title: #77: Qualify ghost users with RFC2307bis and ldap_nesting_level=0 Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/77/head:pr77 git checkout pr77
sssd-devel@lists.fedorahosted.org