3:38 a.m.
URL: https://github.com/SSSD/sssd/pull/5512
Author: sgoveas
Title: #5512: TEST: Add function to control services
Action: opened
PR body:
"""
We can use this function to start stop or restart any service
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5512/head:pr5512
git checkout pr5512
4:29 a.m.
New subject: [sssd PR#5512][synchronized] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Author: sgoveas
Title: #5512: TEST: Add function to control services
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5512/head:pr5512
git checkout pr5512
4:48 a.m.
New subject: [sssd PR#5512][synchronized] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Author: sgoveas
Title: #5512: TEST: Add function to control services
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5512/head:pr5512
git checkout pr5512
4:51 a.m.
New subject: [sssd PR#5512][synchronized] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Author: sgoveas
Title: #5512: TEST: Add function to control services
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5512/head:pr5512
git checkout pr5512
4:57 a.m.
New subject: [sssd PR#5512][+Accepted] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
Label: +Accepted
4:57 a.m.
New subject: [sssd PR#5512][comment] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
madhuriupadhye commented:
"""
Looks good to me.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5512#issuecomment-782000789
7:25 a.m.
New subject: [sssd PR#5512][comment] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
pbrezina commented:
"""
Wouldn't it be better to do it in an OOP way? I.e. provide class for Service with
required methods?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5512#issuecomment-782072472
8:01 a.m.
New subject: [sssd PR#5512][comment] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
sgoveas commented:
"""
Wouldn't it be better to do it in an OOP way? I.e. provide class
for Service with required methods?
this method is part of the sssdTools class, which is used to run commands on specific
vm.
eg.
```
tools = sssdTools(multihost.client[0])
tools.service_ctrl('stop', 'sssd')
```
I think we dont need a separate class to manage the services. Can you elaborate what you
are suggesting?
"""
See the full comment at https://github.com/SSSD/sssd/pull/5512#issuecomment-783396433
4:23 a.m.
New subject: [sssd PR#5512][+Ready to push] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
Label: +Ready to push
4:27 a.m.
New subject: [sssd PR#5512][comment] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
pbrezina commented:
"""
What I do not like is that you started writing tests in python instead of bash, but you
did not get rid of the bashism. You do not take advantage of python, you are instead
converting everything basicly 1 to 1 from bash to python. But this is a discussion for
another place, another day. This is just when it really caught my eyes.
"""
See the full comment at https://github.com/SSSD/sssd/pull/5512#issuecomment-784974819
4:27 a.m.
New subject: [sssd PR#5512][comment] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
pbrezina commented:
"""
Pushed PR: https://github.com/SSSD/sssd/pull/5512
* `master`
* b5c2389bc2978deeba62018115f351876c7b0749 - TEST: Add function to control services
"""
See the full comment at https://github.com/SSSD/sssd/pull/5512#issuecomment-784975143
4:28 a.m.
New subject: [sssd PR#5512][+Pushed] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
Label: +Pushed
4:28 a.m.
New subject: [sssd PR#5512][-Accepted] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
Label: -Accepted
4:28 a.m.
New subject: [sssd PR#5512][-Ready to push] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Title: #5512: TEST: Add function to control services
Label: -Ready to push
4:28 a.m.
New subject: [sssd PR#5512][closed] TEST: Add function to control services
URL: https://github.com/SSSD/sssd/pull/5512
Author: sgoveas
Title: #5512: TEST: Add function to control services
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/5512/head:pr5512
git checkout pr5512
1178
days inactive
1183
days old
sssd-devel@lists.fedorahosted.org
14 comments
3 participants
participants (3)
-
madhuriupadhye -
pbrezina
-
sgoveas