URL:
https://github.com/SSSD/sssd/pull/405
Title: #405: WATCHDOG: Restart providers with SIGUSR2 after time drift
lslebodn commented:
"""
I did some testing and cannot see any new random failures.
So change seems to be fine.
@vtapia I would like to squash following change before pushing patches
`s/strstr/strcmp/`
```
diff --git a/src/util/util_watchdog.c b/src/util/util_watchdog.c
index 024e97fbc..f37748ae8 100644
--- a/src/util/util_watchdog.c
+++ b/src/util/util_watchdog.c
@@ -160,7 +160,7 @@ static void watchdog_fd_read_handler(struct tevent_context *ev,
"[%d]: %s\n", ret, sss_strerror(ret));
orderly_shutdown(1);
}
- if (strstr(debug_prg_name, "sssd[be[") != NULL) {
+ if (strcmp(debug_prg_name, "sssd[be[") == 0) {
kill(getpid(), SIGUSR2);
DEBUG(SSSDBG_IMPORTANT_INFO, "SIGUSR2 sent to %s\n", debug_prg_name);
}
```
Are you fine with such change? And sorry for long review.
"""
See the full comment at
https://github.com/SSSD/sssd/pull/405#issuecomment-346554958