10:55 a.m.
URL: https://github.com/SSSD/sssd/pull/931
Author: miztake
Title: #931: Fix memory leak about krb5 error message
Action: opened
PR body:
"""
krb5 error message obtained with sss_krb5_get_error_message() must be released with
sss_krb5_free_error_message().
It is not released in some message output processes.
Added error message release processing.
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/931/head:pr931
git checkout pr931
10:55 a.m.
New subject: [sssd PR#931][comment] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-552117502
7:21 p.m.
New subject: [sssd PR#931][comment] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
miztake commented:
"""
Is this duplicate with PR#915?
"""
See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-552153081
1:07 a.m.
New subject: [sssd PR#931][comment] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
sumit-bose commented:
"""
Is this duplicate with PR#915?
Hi,
thank you for your patch, but yes, there is an overlap with PR#915. I have not checked it
line-by-line and I would suggest that I'll do the review of PR#915 then it would be
easier to see if your patch covers parts which are not handled by PR#915.
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-552320380
4:12 a.m.
New subject: [sssd PR#931][comment] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
alexey-tikhonov commented:
"""
Hi @miztake,
As PR #915 was merged upstream, could you please check and if needed amend&rebase this
PR?
"""
See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-557014602
4:12 a.m.
New subject: [sssd PR#931][+Changes requested] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
Label: +Changes requested
9:32 a.m.
New subject: [sssd PR#931][comment] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
miztake commented:
"""
Hi, @alexey-tikhonov san
PR#915 includes all of PR#931.
As a result, there are no additional fixes to PR#915.
I'll close this PR.
Thank you for your cooperation.
"""
See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-557578735
9:33 a.m.
New subject: [sssd PR#931][closed] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Author: miztake
Title: #931: Fix memory leak about krb5 error message
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/931/head:pr931
git checkout pr931
10 a.m.
New subject: [sssd PR#931][comment] Fix memory leak about krb5 error message
URL: https://github.com/SSSD/sssd/pull/931
Title: #931: Fix memory leak about krb5 error message
alexey-tikhonov commented:
"""
Thank you for confirming.
"""
See the full comment at https://github.com/SSSD/sssd/pull/931#issuecomment-557589434
1667
days inactive
1680
days old
sssd-devel@lists.fedorahosted.org
8 comments
4 participants
participants (4)
-
alexey-tikhonov -
centos-ci
-
miztake
-
sumit-bose