[sssd PR#658][opened] pytest: Test case for sudo: search with lower cased name for case insensitive domains
5:32 a.m.
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: opened
PR body:
"""
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
5:32 a.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
centos-ci commented:
"""
Can one of the admins verify this patch?
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423132698
6:13 a.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
sumit-bose commented:
"""
ok ot test
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423145060
2:51 p.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
ok to test
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423310772
2:54 p.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
the previous comment had a typo :-) But more importantly, I'm not sure why the centos
CI didn't start automatically. I suspect it was just a PEBKAC and I might have not
clicked 'apply' but only 'save' in the centos jenkins. I've clicked
both now, just to be sure :-]
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423311945
2:55 p.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
the previous comment had a typo :-) But more importantly, I'm not sure why the centos
CI didn't start automatically, @mrniranjan should be in the whitelist by now.
I suspect it was just a PEBKAC and I might have not clicked 'apply' but only
'save' in the centos jenkins when I was adding @mrniranjan to the whitelist.
I've clicked both now, just to be sure :-]
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423311945
2:31 a.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423441455
2:31 a.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
It's strange that the centos CI is failing, the internal CI passed just fine..so I
rescheduled the job, let's see what happens.
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-423441554
6:21 a.m.
New subject: [sssd PR#658][+Changes requested] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
Label: +Changes requested
10:32 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
10:36 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
10:45 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
1:30 p.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
On Mon, Sep 24, 2018 at 05:09:51AM -0700, Niranjan Mallapadi wrote:
mrniranjan commented on this pull request.
> + no_passwd = [(ldap.MOD_ADD, 'sudoOption',
'!authenticate'.encode('utf-8'))]
+ try:
+ (_, _) = ldap_inst.add_entry(sudo_attr1, capsrule_dn1)
+ except LdapException:
+ pytest.fail("Failed to add %s rule in ldap" % (capsrule_dn1))
+ try:
+ (_, _) = ldap_inst.add_entry(sudo_attr2, capsrule_dn2)
+ except LdapException:
+ pytest.fail("Failed to add %s rule in ldap" % (capsrule_dn2))
+ else:
+ (_, _) = ldap_inst.modify_ldap(capsrule_dn1, no_passwd)
+ (_, _) = ldap_inst.modify_ldap(capsrule_dn2, no_passwd)
+
+
+(a)pytest.fixture
+def enable_sss_sudo_nsswitch(session_multihost, tmpdir, request):
authselect doesn't do it by default, Not sure if that's bug, currently authselect
adds sss to passwd,group,netgroup,automount, services.
Also "sudoers: files " entry doesn't exist in default /etc/nsswith.conf
OK, interesting, then this change makes sense.
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-424077897
9:25 p.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
9:34 p.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
10:43 p.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
7:35 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
7:10 a.m.
New subject: [sssd PR#658][-Changes requested] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
Label: -Changes requested
10:46 p.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
mrniranjan commented:
"""
@jhrozek can you review this
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-425612963
5:17 a.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
Thank you for the patches. The tests work. I only have some questions about the patches
inline. But they are not urgent, feel free to fix or not as you see fit.
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-425857548
5:28 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
5:39 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
6:16 a.m.
New subject: [sssd PR#658][+Accepted] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
Label: +Accepted
6:18 a.m.
New subject: [sssd PR#658][synchronized] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
2:30 p.m.
New subject: [sssd PR#658][comment] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
jhrozek commented:
"""
* master:
0e8f9ffe9d34ff664304a8b5f18827b175285eae
56842e706c26cd4cce6a3fbd2e175e844f75887f
78333065761450873a1855aa41e28761299851e2
58d11ae61dfc5d5fb95ee38de10f3637bc8edd53
2ac3efd1173af62c3bb4b8fb3a823330529bbc22
a62caa0e396eac08d4d225142a63003b2b2ba061
4276b3f73d26f9fb7fdd39e1443df5301f96a099
"""
See the full comment at https://github.com/SSSD/sssd/pull/658#issuecomment-426033592
2:30 p.m.
New subject: [sssd PR#658][closed] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Author: mrniranjan
Title: #658: pytest: Test case for sudo: search with lower cased name for case
insensitive domains
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/658/head:pr658
git checkout pr658
2:31 p.m.
New subject: [sssd PR#658][+Pushed] pytest: Test case for sudo: search with lower cased name for case insensitive domains
URL: https://github.com/SSSD/sssd/pull/658
Title: #658: pytest: Test case for sudo: search with lower cased name for case insensitive
domains
Label: +Pushed
2046
days inactive
2057
days old
sssd-devel@lists.fedorahosted.org
26 comments
4 participants
participants (4)
-
centos-ci -
jhrozek
-
mrniranjan
-
sumit-bose