URL: https://github.com/SSSD/sssd/pull/73 Author: celestian Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Action: opened
PR body: """ This is backport of https://fedorahosted.org/sssd/ticket/2828 to 1.13. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/73/head:pr73 git checkout pr73
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
celestian commented: """ Notes: 1. I have experienced issue with ```other then master``` case. I hope it was caused by my broken AD setup. 2. Actually there is a test for logic of configuration option. (```ad_enabled_domains``` adds master domain automatically). But it is not back-ported yet. 3. It is good idea add ```(cherry picked from commit...``` """
See the full comment at https://github.com/SSSD/sssd/pull/73#issuecomment-258861730
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
lslebodn commented: """ Patches does not have "cherry picked from commit" in commit message. In another word, they were not created with the flag "-x"
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/73#issuecomment-258864473
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/73 Author: celestian Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/73/head:pr73 git checkout pr73
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
celestian commented: """ Notes: - [ ] I have experienced issue with ```other then master``` case. I hope it was caused by my broken AD setup. - [ ] Actually there is a test for logic of configuration option. (```ad_enabled_domains``` adds master domain automatically). But it is not back-ported yet. - [x] It is good idea add ```(cherry picked from commit...``` """
See the full comment at https://github.com/SSSD/sssd/pull/73#issuecomment-258861730
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
celestian commented: """ I pushed new version with ```(cherry picked from commit...``` (It is done manually) """
See the full comment at https://github.com/SSSD/sssd/pull/73#issuecomment-259075858
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
jhrozek commented: """ I tested the patches with a setup that consists of three domains (win.trust.test, child.win.trust.test and sibling.win.trust.test). The patch works good, I tested by disabling the global catalog to make sure the connections always hit the AD DC in that particular domain and inspected the subdomains objectclass in the cache.
I also checked for memory errors in valgrind.
Since all my tests passed, ACK to this patch. """
See the full comment at https://github.com/SSSD/sssd/pull/73#issuecomment-259109022
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
lslebodn commented: """ On (08/11/16 03:06), Jakub Hrozek wrote:
I tested the patches with a setup that consists of three domains (win.trust.test, child.win.trust.test and sibling.win.trust.test). The patch works good, I tested by disabling the global catalog to make sure the connections always hit the AD DC in that particular domain and inspected the subdomains objectclass in the cache.
I also checked for memory errors in valgrind.
Since all my tests passed, ACK to this patch.
sssd-1-13: * efba0221c407af832727da26fa45c7aa326c89b9 * 7c7781a6632dc46d73567bf90ba1d0bf1c0e4a17 * 5c9e24c1558c782d2f1bf89724043769953e202d * 854d6513ac5d1b2ba666d6b120e702081bbb1633
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/73#issuecomment-259122034
URL: https://github.com/SSSD/sssd/pull/73 Title: #73: AD_PROVIDER: Enabled subdomains (1.13)
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/73 Author: celestian Title: #73: AD_PROVIDER: Enabled subdomains (1.13) Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/73/head:pr73 git checkout pr73
sssd-devel@lists.fedorahosted.org