URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ I'm sorry for the delay. The code looks good, the smart card login works well, try_cert_auth kicks me out without a smart card, require_cert_auth waits and either proceeds with the login or returns "Authentication service cannot retrieve authentication info". My only comment is about the man page option. I also started the CI and Coverity runs. """ See the full comment at https://github.com/SSSD/sssd/pull/668#issuecomment-428333167

URL: https://github.com/SSSD/sssd/pull/668 Author: sumit-bose Title: #668: pam_sss: add try_cert_auth and require_cert_auth options Action: synchronized To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/668/head:pr668 git checkout pr668

URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ The testing was relatively minimal, but I confirmed that with an incorrect URI, I can't log in and with the correct URI I can. So if you confirm that the return values should not be checked, I'll ack. Coverity was clean. """ See the full comment at https://github.com/SSSD/sssd/pull/668#issuecomment-428530908

URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options sumit-bose commented: """ p11_kit_uri_set_slot_id () does not have a return value (https://p11-glue.github.io/p11-glue/p11-kit/manual/p11-kit-URIs.html#p11-...). I added checks for the C_GetInfo return value in the latest version. """ See the full comment at https://github.com/SSSD/sssd/pull/668#issuecomment-428592344

URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options jhrozek commented: """ * master: 4a22fb6bba6662ad628f6e17203e8ccf20eb9666 725b65081d19da658b16338686c53dcf16d49de0 f7b2152a4c3c816a5bc4226a0e01791313accef3 46fd681a73ffef062cd027e7018e1a02d7a0a9df 5cdb6968f407c7bcaba69f4892f51fd6426dddb2 49be8974b490c368d349752f3196af0c9ed28dd5 d3a18f06162b9585d2db936472b75fdbff37162d d33a8bed5aad9135426c9ebdf101cf600685ab81 2e4ecf5a866b212bef44e262fd90c67a88dc616a 42f69e26e5b858dd03492cc2a148d02c2ccc2161 """ See the full comment at https://github.com/SSSD/sssd/pull/668#issuecomment-428732379

URL: https://github.com/SSSD/sssd/pull/668 Title: #668: pam_sss: add try_cert_auth and require_cert_auth options Label: +Pushed