URL: https://github.com/SSSD/sssd/pull/5297 Author: scabrero Title: #5297: Fix IP network by address lookup Action: opened
PR body: """ Resolves https://github.com/SSSD/sssd/issues/5256.
The first commit fixes the error path when an IP host is not found in the proxy provider. A memory allocation error was logged because we didn't jump to done label after receiving ENOENT.
``` [be[test]] [proxy_save_host] (0x0040): Cannot get cased name. [be[test]] [get_host_byname] (0x0040): Failed to store host [(null)] [12]: Cannot allocate memory ``` """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5297/head:pr5297 git checkout pr5297
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: +Waiting for review
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
sumit-bose commented: """ Hi,
thanks for the fixes. The code looks good. I wonder if you can add a test where `getnetbyaddr()`is called with `AF_UNSPEC` ?
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5297#issuecomment-700524033
URL: https://github.com/SSSD/sssd/pull/5297 Author: scabrero Title: #5297: Fix IP network by address lookup Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5297/head:pr5297 git checkout pr5297
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
scabrero commented: """ Changes from previous version: - Rebase master - Expand comment to note `inet_ntop()`expects network byte order as well. - Fix test_netbyaddr calling `call_sssd_getnetbyname()` instead of `call_sssd_getnetbyaddr()` - Expand `test_netbyaddr` to check `getnetbyaddr` with `AF_INET` and `AF_UNSPEC` """
See the full comment at https://github.com/SSSD/sssd/pull/5297#issuecomment-700594060
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
sumit-bose commented: """ Hi,
thanks for the updates. I think the CI failure on Debian is not related. ACK.
bye, Sumit """
See the full comment at https://github.com/SSSD/sssd/pull/5297#issuecomment-700774464
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: -Waiting for review
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: +Ready to push
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
pbrezina commented: """ Pushed PR: https://github.com/SSSD/sssd/pull/5297
* `master` * 77734063fb390405257d2db432d496c347a4a80b - TESTS: Extend resolver tests to check getnetbyaddr with AF_UNSPEC * 69af6848f0fdb5dcfaa801da0b187b3ffd65ef70 - TESTS: Fix resolver test calling getnetbyname instead of getnetbyaddr * 9edc3c49c29a8cd2dbafbd4c089cf1056d20a399 - TESTS: getnetbyaddr_r expects network in host byte order * a590fd98ebff79652e8e651066cc9be853cbaf65 - PROXY: getnetbyaddr_r expects the net argument in host byte order * 2c456951a84eb5285c384ab1d5063e32d14b907e - NSS: Fix _nss_sss_getnetbyaddr_r address byte order * 9d350e0403bceee6dbeb530b6ba2e3a1937a3664 - NSS: Fix get ip network by address when address type is AF_UNSPEC * 430e695a0339bfc2b989dcd6662e6ac109f1ca12 - PROXY: Fix iphost not found code path in get_host_by_name_internal
"""
See the full comment at https://github.com/SSSD/sssd/pull/5297#issuecomment-701359973
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: +Pushed
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/5297 Title: #5297: Fix IP network by address lookup
Label: -Ready to push
URL: https://github.com/SSSD/sssd/pull/5297 Author: scabrero Title: #5297: Fix IP network by address lookup Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/5297/head:pr5297 git checkout pr5297
sssd-devel@lists.fedorahosted.org
-
alexey-tikhonov -
pbrezina
-
scabrero
-
sumit-bose