URL: https://github.com/SSSD/sssd/pull/314 Author: mzidek-rh Title: #314: SDAP: Add sdap_domain_copy_search_bases Action: opened
PR body: """ Add function to copy search bases from one sdap_domain to another.
Resolves: https://pagure.io/SSSD/sssd/issue/3435 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/314/head:pr314 git checkout pr314
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
fidencio commented: """ @mzidek-rh: just a nitpick ...
From the libraries that I'm used to use (like glib) ... the copy functions are usually following the follow schema: fn_copy(src, dest), which is exactly the opposite done in your patch.
Would you mind changing this? """
See the full comment at https://github.com/SSSD/sssd/pull/314#issuecomment-310061087
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
fidencio commented: """ Hmm. On the other hand, string functions are usually following what you've done: fn_copy(dest, src) ... so, please, ignore my previous comment. """
See the full comment at https://github.com/SSSD/sssd/pull/314#issuecomment-310061555
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
fidencio commented: """ Anyways, patch looks good (although I didn't test it). I'm firing a CI build and will ack after getting the results. """
See the full comment at https://github.com/SSSD/sssd/pull/314#issuecomment-310107917
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
fidencio commented: """ There were 2 failures in our CI, none related to the patches: http://sssd-ci.duckdns.org/logs/job/71/65/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/314#issuecomment-310137798
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/314 Author: mzidek-rh Title: #314: SDAP: Add sdap_domain_copy_search_bases Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/314/head:pr314 git checkout pr314
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
jhrozek commented: """ * master: 386c5f2e134beb6fcfc474f347e226ac0dedfef5 """
See the full comment at https://github.com/SSSD/sssd/pull/314#issuecomment-314399821
URL: https://github.com/SSSD/sssd/pull/314 Title: #314: SDAP: Add sdap_domain_copy_search_bases
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek
-
mzidek-rh