[sssd PR#782][opened] TESTS: Test changing LDAP password with extended operation and modification
URL: https://github.com/SSSD/sssd/pull/782 Author: jhrozek Title: #782: TESTS: Test changing LDAP password with extended operation and modification Action: opened
PR body: """ A test for: https://pagure.io/SSSD/sssd/issue/1314 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/782/head:pr782 git checkout pr782
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
pbrezina commented: """ I believe you can use textwrap.dedent instead of implementing custom unindent function. """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-476555786
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
pbrezina commented: """ pep8 failures: https://s3.eu-central-1.amazonaws.com/sssd-ci/PR-782/10/fedora28/ci-pep8.log """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-477628329
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
jhrozek commented: """ The test needs to have a title added as PR #756 does. """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-479843337
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
pbrezina commented: """ Bump. """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-487522702
URL: https://github.com/SSSD/sssd/pull/782 Author: jhrozek Title: #782: TESTS: Test changing LDAP password with extended operation and modification Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/782/head:pr782 git checkout pr782
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
jhrozek commented: """ Sorry @pbrezina this took too long. Your concerns should be addressed.
@mrniranjan could you check if the title is OK? (Or feel free to check anything else you want :-)) """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-502816575
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
mrniranjan commented: """ @jhrozek Looks good to me. """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-503037185
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
pbrezina commented: """ Ack. """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-503169773
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
jhrozek commented: """ Thank you for the review. * master: * 7ad11b2898925cd65fc145955063c6669814b7d5 * 71ae2eda2fb82306c81cf67753d2d6c5669284af * 2a53df35458fbc25e96e175b95ff49b511f50dae """
See the full comment at https://github.com/SSSD/sssd/pull/782#issuecomment-503280202
URL: https://github.com/SSSD/sssd/pull/782 Author: jhrozek Title: #782: TESTS: Test changing LDAP password with extended operation and modification Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/782/head:pr782 git checkout pr782
URL: https://github.com/SSSD/sssd/pull/782 Title: #782: TESTS: Test changing LDAP password with extended operation and modification
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
jhrozek -
mrniranjan
-
pbrezina