URL: https://github.com/SSSD/sssd/pull/572 Author: sumit-bose Title: #572: winbind idmap plugin: support inferface version 6 Action: opened
PR body: """ With Samba 4.7 the interface version of the idmap plugin was updated to 6. The patch adds support for this new version but can be complied with the older version as well.
A configure option is added to select the version, if no version is given configure tries to detect the version with the help of an internal Samba library libidmap-samba4.so.
To make sure that always the right version is used configure will fail if Samba is used (--with-samba, default) and no version can be determined.
Resolves https://pagure.io/SSSD/sssd/issue/3741 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/572/head:pr572 git checkout pr572
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
abbra commented: """ The test looks good to me. Calling `smb_register_idmap(version, NULL, NULL)` would return either `NT_STATUS_INVALID_PARAMETER` or `NT_STATUS_OBJECT_TYPE_MISMATCH`, without going further, so we are really just check the value of SMB_IDMAP_INTERFACE_VERSION compiled into the Samba private library. """
See the full comment at https://github.com/SSSD/sssd/pull/572#issuecomment-390150243
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
fidencio commented: """ Patches look good. I'm just firing a CI run and I'll add the "Accepted" label as soon as I get the results. """
See the full comment at https://github.com/SSSD/sssd/pull/572#issuecomment-390186788
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
fidencio commented: """ Ack! CI: http://sssd-ci.$%7Bidm%7D/job/ci/8930/ """
See the full comment at https://github.com/SSSD/sssd/pull/572#issuecomment-390211974
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
fidencio commented: """ master: c6b99b0 """
See the full comment at https://github.com/SSSD/sssd/pull/572#issuecomment-390243490
URL: https://github.com/SSSD/sssd/pull/572 Author: sumit-bose Title: #572: winbind idmap plugin: support inferface version 6 Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/572/head:pr572 git checkout pr572
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/572 Title: #572: winbind idmap plugin: support inferface version 6
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
abbra -
fidencio
-
sumit-bose