URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

lslebodn commented: """ On (06/02/18 12:41), fidencio wrote:

Many warnings have been updated a few days ago with those changes: https://github.com/coreutils/gnulib/blob/master/m4/manywarnings.m4

I'd prefer to have PR #378 updated, reviewed and merged before having these patches reviewed and merged.

PR#378 is unrelated to this PR and this PR does not add any new warnings into Makefile.am. I noticed warnings on my laptop which already has gcc8.

And it is little bit annoying that I cannot rebase patches on top current master but I need to rebase on my local gcc8 branch due to these warnings.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/508#issuecomment-363821830

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

fidencio commented: """ I understand your frustration, @lslebodn. I've been doing that for one year and a half now.

Please, let's have PR #378 reviewed and then we can have this one merged. """

See the full comment at https://github.com/SSSD/sssd/pull/508#issuecomment-364020958

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

fidencio commented: """ So, just a bunch of nitpicks, but the patches are good.

Please, fix the nitpicks, re-update the patches and let's have them merged.

- **AD: Suppress warning Wincompatible-pointer-types with sasl callbacks**: Hovever -> However - **CRYPTO: Suppress warning Wstringop-truncation**: Please, align the text in the commit message - **pysss: Suppress warning Wincompatible-pointer-types**: struct have -> struct has - **pysss: Drop unused parameter**: struct have -> struct has - **CLIENT: Fix warning Wstringop-overflow**: alocate -> allocate - **INOTIFY: Fix warning Wstringop-truncation**: ack! - **CLIENT: Fix warning Wstringop-overflow**: ack! """

See the full comment at https://github.com/SSSD/sssd/pull/508#issuecomment-364065725

URL: https://github.com/SSSD/sssd/pull/508 Author: lslebodn Title: #508: Fix/suppress few gcc8 warnings Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/508/head:pr508 git checkout pr508

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

Label: -Changes requested

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

lslebodn commented: """ On (07/02/18 23:39), fidencio wrote:

Anyways, your comment makes sense. Blocking someone's work for no strong reason is not an attitude that I've liked to face (although I had to).

That's different levels of blocking.

There are some PRs (not just yours :-) #237 #378 #391 ...) which has not been reviewed for quite a long). Sure they are blocked. But it is a different level if you cannot compile project itself without warnings/errors. In such situation, you cannot easily review/test others PRs.

I know that we are all busy. Maybe we should add label "prioritized" to distinguish such PRs. Hopefully it will not be misused.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/508#issuecomment-364172668

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

fidencio commented: """ Btw, I am from the mobile now a days I didn't find a way to add the Accepted label. If someone else can do that for me, that would be appreciated. """

See the full comment at https://github.com/SSSD/sssd/pull/508#issuecomment-365191589

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

lslebodn commented: """ master: * bd5f48540b25dae81c43feb1d6aba4175da52098 * fcf6a9f34c475b9bbae54311703e87acd5fb8d1a * c53997720b231ad61af435a3124c7ecd731fc99b * 2951a9a84bd85f384213a3e071ffc167907df2d7 * 187f68360de1e452afce699706a4253f3fc71a1f * 35eb23755657e76ac600bae512846a4e485997e5 * 1b6965fd09e4e6a6b5ba76b8221ca3980bcc56b4 """

See the full comment at https://github.com/SSSD/sssd/pull/508#issuecomment-365287426

URL: https://github.com/SSSD/sssd/pull/508 Title: #508: Fix/suppress few gcc8 warnings

Label: +Pushed