URL: https://github.com/SSSD/sssd/pull/299 Author: lslebodn Title: #299: pam_sss: Fix leaking of memory in case of failures Action: opened
PR body: """ Found by coverity. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/299/head:pr299 git checkout pr299
URL: https://github.com/SSSD/sssd/pull/299 Author: lslebodn Title: #299: pam_sss: Fix leaking of memory in case of failures Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/299/head:pr299 git checkout pr299
URL: https://github.com/SSSD/sssd/pull/299 Title: #299: pam_sss: Fix leaking of memory in case of failures
lslebodn commented: """
As far as I understand (and my understanding may be wrong, that's the reason I'm trying to have it clear as crystal here) we would be leaking "prompt" in a few other places below as well, unless prompt gets free'd() inside conv->conv(). Do you know if that's the case?
Good point.
I briefly checked source code of LinuxPAM and could not find anything about clean-up in conversation function. @sumit-bose could you double check?
BTW updated version was pushed. """
See the full comment at https://github.com/SSSD/sssd/pull/299#issuecomment-306157238
URL: https://github.com/SSSD/sssd/pull/299 Title: #299: pam_sss: Fix leaking of memory in case of failures
sumit-bose commented: """ Patch looks good and is needed. ACK from my side, @fidencio are your concerns taken care of? """
See the full comment at https://github.com/SSSD/sssd/pull/299#issuecomment-307144529
URL: https://github.com/SSSD/sssd/pull/299 Title: #299: pam_sss: Fix leaking of memory in case of failures
fidencio commented: """ Yes, they are.
Adding the "Accepted" label. """
See the full comment at https://github.com/SSSD/sssd/pull/299#issuecomment-307152829
URL: https://github.com/SSSD/sssd/pull/299 Title: #299: pam_sss: Fix leaking of memory in case of failures
Label: +Accepted
sssd-devel@lists.fedorahosted.org
-
fidencio -
lslebodn
-
sumit-bose