-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
We were cleaning up all groups that were expired and for which there existed no user with memberOf: <thegroup> as an attribute.
This patch modifies the search to also check for cached users with this group's GID as their primary GID.
Fixes https://fedorahosted.org/sssd/ticket/624
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Wed, 03 Nov 2010 07:45:24 -0400 Stephen Gallagher sgallagh@redhat.com wrote:
*/subfilter = talloc_asprintf(tmpctx, "(|(%s=%s)(%s=%u))",SYSDB_MEMBEROF, dn,SYSDB_GIDNUM, gid); if (!subfilter) {
NACK, change the filter to use %lu and cast gid to (long unsigned) and then it is an ack. Although currently an id is an unsigned 32bit integere it is better to play safe here and do an explicit cast to a type know to snprintf and big enough to contain the value.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 11/03/2010 08:23 AM, Simo Sorce wrote:
On Wed, 03 Nov 2010 07:45:24 -0400 Stephen Gallagher sgallagh@redhat.com wrote:
*/subfilter = talloc_asprintf(tmpctx, "(|(%s=%s)(%s=%u))",SYSDB_MEMBEROF, dn,SYSDB_GIDNUM, gid); if (!subfilter) {NACK, change the filter to use %lu and cast gid to (long unsigned) and then it is an ack. Although currently an id is an unsigned 32bit integere it is better to play safe here and do an explicit cast to a type know to snprintf and big enough to contain the value.
Good catch, thanks.
New patch attached.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
On Wed, 03 Nov 2010 08:30:15 -0400 Stephen Gallagher sgallagh@redhat.com wrote:
NACK, change the filter to use %lu and cast gid to (long unsigned) and then it is an ack. Although currently an id is an unsigned 32bit integere it is better to play safe here and do an explicit cast to a type know to snprintf and big enough to contain the value.
Good catch, thanks.
New patch attached.
ACK.
Simo.
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
On 11/03/2010 08:42 AM, Simo Sorce wrote:
On Wed, 03 Nov 2010 08:30:15 -0400 Stephen Gallagher sgallagh@redhat.com wrote:
NACK, change the filter to use %lu and cast gid to (long unsigned) and then it is an ack. Although currently an id is an unsigned 32bit integere it is better to play safe here and do an explicit cast to a type know to snprintf and big enough to contain the value.
Good catch, thanks.
New patch attached.
ACK.
Pushed to master.
- -- Stephen Gallagher RHCE 804006346421761
Delivering value year after year. Red Hat ranks #1 in value among software vendors. http://www.redhat.com/promo/vendor/
sssd-devel@lists.fedorahosted.org
-
Simo Sorce -
Stephen Gallagher