[sssd PR#265][opened] Test for issue #3391 (sss_override doesn't work with files provider)
URL: https://github.com/SSSD/sssd/pull/265 Author: fidencio Title: #265: Test for issue #3391 (sss_override doesn't work with files provider) Action: opened
PR body: """ This patch includes the test for overriden user using files provider and it's expected to fail till we have a fix for issue #3391. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/265/head:pr265 git checkout pr265
URL: https://github.com/SSSD/sssd/pull/265 Author: fidencio Title: #265: Test for issue #3391 (sss_override doesn't work with files provider) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/265/head:pr265 git checkout pr265
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
sumit-bose commented: """ The test looks good and passes with my patches after the change mentioned above. I wonder if for completeness you'd like to add a test for group overrides as well? """
See the full comment at https://github.com/SSSD/sssd/pull/265#issuecomment-313430563
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
sumit-bose commented: """ Patches for the issue itself can be found at https://github.com/SSSD/sssd/pull/317.
"""
See the full comment at https://github.com/SSSD/sssd/pull/265#issuecomment-313437331
URL: https://github.com/SSSD/sssd/pull/265 Author: fidencio Title: #265: Test for issue #3391 (sss_override doesn't work with files provider) Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/265/head:pr265 git checkout pr265
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
fidencio commented: """ @sumit-bose: patch updated according to your review. """
See the full comment at https://github.com/SSSD/sssd/pull/265#issuecomment-314076682
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
sumit-bose commented: """ If I apply the patch on top of #317 the tests pass:
test_files_provider.py::test_user_overriden PASSED test_files_provider.py::test_group_overriden PASSED
So, ACK.
If #317 is committed I would expect that the CI test here will pass as well. I guess the best way to proceed is to wait until #317 is commited rerun the CI test and if successful switch this PR to Accepted. """
See the full comment at https://github.com/SSSD/sssd/pull/265#issuecomment-314401496
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
jhrozek commented: """ retest this please """
See the full comment at https://github.com/SSSD/sssd/pull/265#issuecomment-314403161
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
jhrozek commented: """ * master: b294f9f082c97f0c6ef16739e19826a16375444e """
See the full comment at https://github.com/SSSD/sssd/pull/265#issuecomment-316007370
URL: https://github.com/SSSD/sssd/pull/265 Author: fidencio Title: #265: Test for issue #3391 (sss_override doesn't work with files provider) Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/265/head:pr265 git checkout pr265
URL: https://github.com/SSSD/sssd/pull/265 Title: #265: Test for issue #3391 (sss_override doesn't work with files provider)
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio -
jhrozek
-
sumit-bose