URL: https://github.com/SSSD/sssd/pull/298 Author: lslebodn Title: #298: pam_sss: Fix checking of empty string cert_user Action: opened
PR body: """ src/sss_client/pam_sss.c: In function ‘eval_response’: src/sss_client/pam_sss.c:998:64: error: comparison between pointer and zero character constant [-Werror=pointer-compare] if (type == SSS_PAM_CERT_INFO && pi->cert_user == '\0') { ^~ src/sss_client/pam_sss.c:998:50: note: did you mean to dereference the pointer? if (type == SSS_PAM_CERT_INFO && pi->cert_user == '\0') { ^ src/sss_client/pam_sss.c:1010:42: error: comparison between pointer and zero character constant [-Werror=pointer-compare] && pi->cert_user != '\0') { ^~ src/sss_client/pam_sss.c:1010:28: note: did you mean to dereference the pointer? && pi->cert_user != '\0') { """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/298/head:pr298 git checkout pr298
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/70/90/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/298#issuecomment-306108144
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
fidencio commented: """ Ack! """
See the full comment at https://github.com/SSSD/sssd/pull/298#issuecomment-306108165
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
lslebodn commented: """ master: * c62dc2ac02253e130991db0f6acd60ce1a2753f1 """
See the full comment at https://github.com/SSSD/sssd/pull/298#issuecomment-306213208
URL: https://github.com/SSSD/sssd/pull/298 Author: lslebodn Title: #298: pam_sss: Fix checking of empty string cert_user Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/298/head:pr298 git checkout pr298
URL: https://github.com/SSSD/sssd/pull/298 Title: #298: pam_sss: Fix checking of empty string cert_user
Label: +Pushed
sssd-devel@lists.fedorahosted.org