12:41 p.m.
URL: https://github.com/SSSD/sssd/pull/1012
Author: thalman
Title: #1012: config: add dns_resolver_op_timeout to option list
Action: opened
PR body:
"""
Resolves:
https://pagure.io/SSSD/sssd/issue/3217
This is backport of commit 049f3906b9 into 1-16 branch
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1012/head:pr1012
git checkout pr1012
12:42 p.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented:
"""
Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1719718
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-604575880
7:05 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
sumit-bose commented:
"""
Hi,
```
diff --git a/src/config/etc/sssd.api.conf b/src/config/etc/sssd.api.conf
index 0747dea..882aa2a 100644
--- a/src/config/etc/sssd.api.conf
+++ b/src/config/etc/sssd.api.conf
@@ -217,3 +217,4 @@ dyndns_server = str, None, false
[provider/deny]
[provider/deny/access]
+# Please do not remove
```
The line after the section header is important for the tests. Not sure if the tests can be
fixed easy, if not please keep the empty line at the end.
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-604963858
9:20 a.m.
New subject: [sssd PR#1012][synchronized] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Author: thalman
Title: #1012: config: add dns_resolver_op_timeout to option list
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1012/head:pr1012
git checkout pr1012
9:21 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented:
"""
The line after the section header is important for the tests. Not sure if the tests can
be fixed easy, if not please keep the empty line at the end.
bye,
Sumit
Fixed
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-605027150
9:21 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented:
"""
The line after the section header is important for the tests. Not sure if the tests can
be fixed easy, if not please keep the empty line at the end.
bye,
Sumit
Fixed
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-605027150
10:22 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
sumit-bose commented:
"""
Hi,
thanks, testing went well. I finally just want to ask if you can replace the
'Resolves: https://pagure.io/SSSD/sssd/issue/3217' with 'Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1719718' because #3217 gives imo a wrong
impression here.
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-606066029
10:29 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
pbrezina commented:
"""
Hi,
thanks, testing went well. I finally just want to ask if you can replace the
'Resolves: https://pagure.io/SSSD/sssd/issue/3217' with 'Resolves:
https://bugzilla.redhat.com/show_bug.cgi?id=1719718' because #3217 gives imo a wrong
impression here.
Or ideally clone the bugzilla to upstream and reference this new ticket.
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-606070053
8:30 a.m.
New subject: [sssd PR#1012][synchronized] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Author: thalman
Title: #1012: config: add dns_resolver_op_timeout to option list
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1012/head:pr1012
git checkout pr1012
8:33 a.m.
New subject: [sssd PR#1012][+Waiting for review] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Waiting for review
8:34 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
thalman commented:
"""
@pbrezina, @sumit-bose BZ cloned to pagure and referenced from commit message.
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-606631048
4:41 a.m.
New subject: [sssd PR#1012][comment] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
sumit-bose commented:
"""
Thanks, ACK.
bye,
Sumit
"""
See the full comment at https://github.com/SSSD/sssd/pull/1012#issuecomment-607147091
4:41 a.m.
New subject: [sssd PR#1012][-Waiting for review] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: -Waiting for review
4:41 a.m.
New subject: [sssd PR#1012][+Accepted] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Accepted
5:13 a.m.
New subject: [sssd PR#1012][+Ready to push] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Ready to push
4:29 a.m.
New subject: [sssd PR#1012][+Pushed] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: +Pushed
4:29 a.m.
New subject: [sssd PR#1012][-Accepted] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: -Accepted
4:29 a.m.
New subject: [sssd PR#1012][-Ready to push] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Title: #1012: config: add dns_resolver_op_timeout to option list
Label: -Ready to push
4:29 a.m.
New subject: [sssd PR#1012][closed] config: add dns_resolver_op_timeout to option list
URL: https://github.com/SSSD/sssd/pull/1012
Author: thalman
Title: #1012: config: add dns_resolver_op_timeout to option list
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/1012/head:pr1012
git checkout pr1012
1495
days inactive
1503
days old
sssd-devel@lists.fedorahosted.org
18 comments
3 participants
participants (3)
-
pbrezina -
sumit-bose
-
thalman