URL: https://github.com/SSSD/sssd/pull/303 Author: pbrezina Title: #303: IFP: Add domain and domainname attributes to the user Action: opened
PR body: """ org.freedekstop.sssd.infopipe.Users.User gets two new attributes: - domain: object path of user's domain - domainname: user's domain name
org.freedekstop.sssd.infopipe.GetUserAttr can now request new attribute: - domainname: user's domain name
Resolves: https://pagure.io/SSSD/sssd/issue/2714 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/303/head:pr303 git checkout pr303
URL: https://github.com/SSSD/sssd/pull/303 Title: #303: IFP: Add domain and domainname attributes to the user
fidencio commented: """ Testing: - org.freedesktop.sssd.infopipe.Users.User:
``` [root@client1 x86_64]# dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users org.freedesktop.sssd.infopipe.Users.FindByName string:"admin" method return time=1496990920.218104 sender=:1.88 -> destination=:1.93 serial=15 reply_serial=2 object path "/org/freedesktop/sssd/infopipe/Users/ipa_2eexample/1790400000"
[root@client1 x86_64]# dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users/ipa_2eexample/1790400000 org.freedesktop.DBus.Properties.Get string:"org.freedesktop.sssd.infopipe.Users.User" string:"domain" method return time=1496990928.699156 sender=:1.88 -> destination=:1.94 serial=17 reply_serial=2 variant object path "/org/freedesktop/sssd/infopipe/Domains/ipa_2eexample"
[root@client1 x86_64]# dbus-send --system --print-reply --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe/Users/ipa_2eexample/1790400000 org.freedesktop.DBus.Properties.Get string:"org.freedesktop.sssd.infopipe.Users.User" string:"domainname" method return time=1496990932.025692 sender=:1.88 -> destination=:1.95 serial=19 reply_serial=2 variant string "ipa.example" ```
- org.freedekstop.sssd.infopipe.GetUserAttr: ``` [root@client1 x86_64]# dbus-send --print-reply --system --dest=org.freedesktop.sssd.infopipe /org/freedesktop/sssd/infopipe org.freedesktop.sssd.infopipe.GetUserAttr string:"admin" array:string:domainname method return time=1496991218.956655 sender=:1.98 -> destination=:1.97 serial=5 reply_serial=2 array [ dict entry( string "domainname" variant array [ string "ipa.example" ] ) ] ``` """
See the full comment at https://github.com/SSSD/sssd/pull/303#issuecomment-307311137
URL: https://github.com/SSSD/sssd/pull/303 Title: #303: IFP: Add domain and domainname attributes to the user
fidencio commented: """ Patch looks good. I've fired a CI build and I'll ACK it as soon as I get the results. """
See the full comment at https://github.com/SSSD/sssd/pull/303#issuecomment-307312092
URL: https://github.com/SSSD/sssd/pull/303 Author: pbrezina Title: #303: IFP: Add domain and domainname attributes to the user Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/303/head:pr303 git checkout pr303
URL: https://github.com/SSSD/sssd/pull/303 Title: #303: IFP: Add domain and domainname attributes to the user
fidencio commented: """ CI: http://sssd-ci.duckdns.org/logs/job/71/31/summary.html
There's one failure on Fedora 23 but is not related.
ACK! """
See the full comment at https://github.com/SSSD/sssd/pull/303#issuecomment-307346662
URL: https://github.com/SSSD/sssd/pull/303 Title: #303: IFP: Add domain and domainname attributes to the user
Label: +Accepted
sssd-devel@lists.fedorahosted.org