1:12 p.m.
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: opened
PR body:
"""
As said by the commit log, this PR enables pep8 check in our CI.
I really would appreciate to hear @lslebodn's feedback on the patch itself, so I can
revisit the commit dropped by @jhrozek that fixes all pep8 warnings and have it added to
this series.
Anyways, the feedback I'm looking for is basically: Is this patch desired? Is this the
right approach? If not, what would you suggest?
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
1:33 p.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Btw, CI obviously fails due to the pip8 check.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328295582
4:47 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
jhrozek commented:
"""
Well, I applied the patch on top of the old pep8 PR and submitted to CI, let's see
what results we get.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328801790
4:47 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
jhrozek commented:
"""
(Then it would make sense to resubmit both in the same PR)
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328801865
5:32 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
It's not going to work, @jhrozek. We have .py files in a few different places than in
our tests and those will have to be fixed as well in case this PR is desired.
Another option would be to just check or tests (then I'd have to modify this PR a
little bit).
So, those are the things that I'm not sure what would be the desired approach for the
project.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328812578
3:49 p.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
jhrozek commented:
"""
Well, yeah, all our python code should conform to pep8. I sent a PR some time ago that
tried to reformat the tests but I don't have any time to rework it or check for other
issues in other files, sorry.
But I like your approach, perhaps the patch could check the files under the integration
test directory first?
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328980181
4:12 p.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
On Tue, Sep 12, 2017 at 10:49 PM, Jakub Hrozek <notifications(a)github.com>
wrote:
Well, yeah, all our python code should conform to pep8. I sent a PR
some
time ago that tried to reformat the tests but I don't have any time to
rework it or check for other issues in other files, sorry.
But I like your approach, perhaps the patch could check the files under
the integration test directory first?
Okay. I'll re-work your patch (according to @lslebodn suggestions), re-work
my patch according to your suggestion (on focusing in the integration tests
directory firstly) and re-submit the PR.
Thanks for the feedback.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-328985870
3:29 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
On Wednesday, September 13, 2017, lslebodn <notifications(a)github.com> wrote:
*@lslebodn* commented on this pull request.
------------------------------
In contrib/ci/run
<https://github.com/SSSD/sssd/pull/379#discussion_r138553817>;:
> @@ -378,6 +378,7 @@ export V=1
if "$DEPS"; then
stage install-deps deps_install
fi
+stage pep8 find . -name \*.py -exec pep8 {} +
I would limit pep8 check to src/tests/intg/ because SSSDConfig in
src/config have 380 pep8 violation
And I would like to avoid fixing it ourself. We can create "easyfix"
ticket for that
Right. I will limit this to src/tests/intg then, create a new ticket,
rework this PR and re-submit it.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<https://github.com/SSSD/sssd/pull/379#pullrequestreview-62361847>;, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAG4epTt7TFfkPQxXZuHQsY...
.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329096675
3:30 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
Thank you very for writing this test. Boring checks is better to automatize :-)
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329096965
3:30 a.m.
New subject: [sssd PR#379][+Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Changes requested
9:29 a.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
3:17 p.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
3:29 p.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
retest this, please
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329287584
12:33 a.m.
New subject: [sssd PR#379][+Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Changes requested
12:33 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Seems that I broke one of the integration tests and there are more issues on debian.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329378299
1:28 a.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
1:29 a.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
1:31 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Okay. I still have some issues with debian and those I'm not exactly sure how to
solve, thus I'd appreciate if I can get some help from someone who's either a
little bit more familiar with the code or a little bit more familiar with python itself.
Here are the issues (all of those about using except without a specific exception type):
```
Start: Thu Sep 14 08:26:49 CEST 2017
+ find . -path ./src/config -prune -o -name '*.py' -exec pep8 '{}' +
./src/tests/intg/test_secrets.py:67:13: E722 do not use bare except'
./src/tests/intg/test_session_recording.py:44:9: E722 do not use bare except'
./src/tests/intg/test_session_recording.py:71:5: E722 do not use bare except'
./src/tests/intg/test_session_recording.py:203:13: E722 do not use bare except'
./src/tests/intg/test_session_recording.py:206:5: E722 do not use bare except'
./src/tests/intg/test_sssctl.py:45:5: E722 do not use bare except'
./src/tests/intg/test_sssctl.py:88:9: E722 do not use bare except'
./src/tests/intg/test_sssctl.py:101:9: E722 do not use bare except'
./src/tests/intg/test_ts_cache.py:54:5: E722 do not use bare except'
./src/tests/intg/test_ts_cache.py:102:9: E722 do not use bare except'
./src/tests/intg/test_ts_cache.py:115:9: E722 do not use bare except'
./src/tests/intg/test_enumeration.py:48:5: E722 do not use bare except'
./src/tests/intg/test_enumeration.py:197:13: E722 do not use bare except'
./src/tests/intg/test_enumeration.py:200:5: E722 do not use bare except'
./src/tests/intg/test_kcm.py:62:5: E722 do not use bare except'
./src/tests/intg/test_kcm.py:100:13: E722 do not use bare except'
./src/tests/intg/test_local_domain.py:39:9: E722 do not use bare except'
./src/tests/intg/test_local_domain.py:61:9: E722 do not use bare except'
./src/tests/intg/test_netgroup.py:48:5: E722 do not use bare except'
./src/tests/intg/test_netgroup.py:166:13: E722 do not use bare except'
./src/tests/intg/test_netgroup.py:169:5: E722 do not use bare except'
./src/tests/intg/test_files_provider.py:98:9: E722 do not use bare except'
./src/tests/intg/test_files_provider.py:123:9: E722 do not use bare except'
./src/tests/intg/test_memory_cache.py:45:5: E722 do not use bare except'
./src/tests/intg/test_memory_cache.py:88:9: E722 do not use bare except'
./src/tests/intg/test_memory_cache.py:101:9: E722 do not use bare except'
./src/tests/intg/ldap_local_override_test.py:63:5: E722 do not use bare except'
./src/tests/intg/ldap_local_override_test.py:106:9: E722 do not use bare except'
./src/tests/intg/ldap_local_override_test.py:130:9: E722 do not use bare except'
./src/tests/intg/ldap_local_override_test.py:171:9: E722 do not use bare except'
./src/tests/intg/test_ldap.py:55:5: E722 do not use bare except'
./src/tests/intg/test_ldap.py:209:13: E722 do not use bare except'
./src/tests/intg/test_ldap.py:212:5: E722 do not use bare except'
End: Thu Sep 14 08:26:53 CEST 2017
```
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329386826
3:55 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
jhrozek commented:
"""
I suspect Debian uses a different Python version that carries a different pep8 check. I
wonder if any of the Python developers from the IPA team can help us. Can you check with
them?
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329418513
3:56 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
jhrozek commented:
"""
cc @tiran
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-329418574
3:15 a.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
3:16 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have provided a workaround for the issues pointed out in one of my comments.
That may be a way to go ...
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330464728
3:16 a.m.
New subject: [sssd PR#379][-Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
5:51 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
CI: http://vm-058-233.${abc}/logs/job/77/61/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330502831
7:35 a.m.
New subject: [sssd PR#379][+Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Changes requested
9:10 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
@lslebodn, @jhrozek: I'll follow a different approach in case you guys are fine.
Basically what I'm going to do is combine all the ignored by default warnings in all
our supported systems (RHEL6, RHEL7, Fedora 22, Fedora 23, Fedora 24, Fedora 25, Fedora
26, Fedora 27, Fedora Rawhide, Debian Testing).
In this way we can be consistent across our CI, at least.
Is that okay for both of you?
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330551653
12:40 p.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
12:41 p.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have updated the patch set.
This new version has the each issue fixed explained and also the ones found just on this
or that distro also explained where they were found.
CI is already running and I'll add the link here when it's finished.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330616509
12:45 p.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
12:47 p.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
12:47 p.m.
New subject: [sssd PR#379][-Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
2:46 p.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
CI: http://vm-058-233.${abc}/logs/job/77/70/summary.html
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330652762
7:22 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
Reverting "intg: Disable add_remove tests" and adding it back is not nice.
Much better would be to fix https://pagure.io/SSSD/sssd/issue/3463 and it would be much
better spent time of core developer then fixing coding style issues (pep8) in python.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330834835
7:23 a.m.
New subject: [sssd PR#379][+Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Changes requested
7:24 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
We do not have a tracking ticket for enforcing pep8 check therefore I cannot set ticket
https://pagure.io/SSSD/sssd/issue/3463 as a blocker for enforcing pep8. Therefore label
"Changes requested" was added.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330835121
7:33 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Man, that you have some serious problems with language is quite clear ... but,
unfortunately, seems you also have some really serious problems with reading. Let me copy
a comment made a few days ago here in order to help you:
"I can totally drop the following patches in case we decide to wait to apply this
patch set just after our tests are fixed.
Revert "intg: Disable add_remove tests"
intg: Disable add_remove tests
"
Now, in case you have some issues with the way I'm distributing my working time,
please, talk to our manager about that.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-330837169
2:42 a.m.
New subject: [sssd PR#379][synchronized] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
2:43 a.m.
New subject: [sssd PR#379][-Changes requested] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: -Changes requested
2:44 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
I have updated the patch set and fired a CI build.
I'd really appreciate if we can have this one pushed as soon as our internal CI passes
and then avoid having to fix pep8 issues in the future.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351645270
2:47 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Hmm. And seems that I will have to re-work these patches as more new issues have been
added meanwhile this patch was stuck. :-/
We **really** have to have a better way to handle PRs as it's not the first time it
happens ...
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351645912
3:27 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
On (14/12/17 08:47), fidencio wrote:
We **really** have to have a better way to handle PRs as it's not
the first time it happens ...
pep8 is only about coding style it does not make code safer or better.
And we are not consistent in coding style even in C part.
Coding style was never a priority and I cannot see a reason why
core developer need to sped a time with fixing coding style issues
It is a trivial task and can be labeled as "easyfix" in pagure.
Anyway, thank you very much for the effort and I can a big value in
automated checking in CI script.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351655604
4:08 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
As per @lslebodn's comments I understand that SSSD project has **no** interest on this
PR at the moment.
I've opened https://pagure.io/SSSD/sssd/issue/3605 and I'm closing this PR.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351666173
4:08 a.m.
New subject: [sssd PR#379][+Rejected] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
Label: +Rejected
4:08 a.m.
New subject: [sssd PR#379][closed] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Author: fidencio
Title: #379: CI: Enable pep8 check
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/379/head:pr379
git checkout pr379
4:14 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
tiran commented:
"""
As a software developer with over 20 years of coding experience and involved in lots of
Open Source projects written in C, Go and Python, I have to disagree with you. A
consistent code style and static code analysis makes code better and safer.
[OpenSSL](https://www.openssl.org/blog/blog/2015/02/11/code-reformat-finis... and
LibreSSL reformatted their code for good reasons. The whole OpenShift/Kubernetes community
(figuratively all of Go) agrees with me.
Tools like pep8 and pylint detect not only badly formatted code which are harder to read
and maintain, they also find bugs. Unless you have 100% test coverage and 100% branch
coverage, you want to have static code checkers.
You don't have to waste any time on doing PEP8 reformatting yourself. Just hook up
[autopep8](https://pypi.python.org/pypi/autopep8) and
[indent](https://linux.die.net/man/1/indent) and let it autoformat your code on every
push.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351667558
4:55 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
On (14/12/17 10:08), fidencio wrote:
As per @lslebodn's comments I understand that SSSD project has
**no** interest on this PR at the moment.
Please do not put words to my mouth. I have never wrote that there is **no**
interest. I wrote that we are not consistent in coding style and coding style
was never a priority in our project.
Than you for filing an upstream ticket + marking it as easy fix.
LS
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351677667
5:03 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
fidencio commented:
"""
Well, when a PR is not reviewed and the comments come with:
"Coding style was never a priority and I cannot see a reason why
core developer need to sped a time with fixing coding style issues
It is a trivial task and can be labeled as "easyfix" in pagure."
It's a clear indication that there's **no** interest on having this PR merged.
Otherwise, it could be reviewed and merged.
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351679542
5:32 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
cigarette
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351685924
5:38 a.m.
New subject: [sssd PR#379][comment] CI: Enable pep8 check
URL: https://github.com/SSSD/sssd/pull/379
Title: #379: CI: Enable pep8 check
lslebodn commented:
"""
cigarette
"""
See the full comment at https://github.com/SSSD/sssd/pull/379#issuecomment-351685924
2341
days inactive
2437
days old
sssd-devel@lists.fedorahosted.org
48 comments
4 participants
participants (4)
-
fidencio -
jhrozek
-
lslebodn
-
tiran