On Thu, 2012-03-29 at 16:27 -0400, Jakub Hrozek wrote: > https://fedorahosted.org/sssd/ticket/1249 > > The patch also reduces code duplication between several error handling > switch/case statements and fixes a bug in get_initgr where we would try > to cancel a transaction immediately after committing it. > > Do we also want to canonicalize group names in a similar fashion? To be > honest, downloading the whole group twice just for the sake of > determining the correct group name seems a little too much to me.. Nack. As Jakub and I discussed on IRC, we do need to canonicalize group names for correctness' sake. We can also opt to add a new option to prioritize speed over correctness.

On Thu, 2012-04-12 at 20:01 +0200, Jakub Hrozek wrote: > On Thu, Apr 05, 2012 at 04:02:41PM -0700, Stephen Gallagher wrote: > > On Thu, 2012-03-29 at 16:27 -0400, Jakub Hrozek wrote: > > > https://fedorahosted.org/sssd/ticket/1249 > > > > > > The patch also reduces code duplication between several error handling > > > switch/case statements and fixes a bug in get_initgr where we would try > > > to cancel a transaction immediately after committing it. > > > > > > Do we also want to canonicalize group names in a similar fashion? To be > > > honest, downloading the whole group twice just for the sake of > > > determining the correct group name seems a little too much to me.. > > > > Nack. As Jakub and I discussed on IRC, we do need to canonicalize group > > names for correctness' sake. We can also opt to add a new option to > > prioritize speed over correctness. > > I'm sorry for the delay. Attached are two patches - one that always > canonicalizes group and user names and one that adds a new option to > canonicalize from cache. Patch 0001: Ack Patch 0002: Nack (minor) Please lower the debug level on the cache-miss for sysdb_get*id(). It's going to be fairly common and SSSDBG_MINOR_FAILURE is too noisy. Use SSSDBG_TRACE_FUNC instead.

On Wed, 2012-04-18 at 21:56 +0200, Jakub Hrozek wrote: > On Wed, Apr 18, 2012 at 12:36:58PM -0400, Stephen Gallagher wrote: > > On Thu, 2012-04-12 at 20:01 +0200, Jakub Hrozek wrote: > > > On Thu, Apr 05, 2012 at 04:02:41PM -0700, Stephen Gallagher wrote: > > > > On Thu, 2012-03-29 at 16:27 -0400, Jakub Hrozek wrote: > > > > > https://fedorahosted.org/sssd/ticket/1249 > > > > > > > > > > The patch also reduces code duplication between several error handling > > > > > switch/case statements and fixes a bug in get_initgr where we would try > > > > > to cancel a transaction immediately after committing it. > > > > > > > > > > Do we also want to canonicalize group names in a similar fashion? To be > > > > > honest, downloading the whole group twice just for the sake of > > > > > determining the correct group name seems a little too much to me.. > > > > > > > > Nack. As Jakub and I discussed on IRC, we do need to canonicalize group > > > > names for correctness' sake. We can also opt to add a new option to > > > > prioritize speed over correctness. > > > > > > I'm sorry for the delay. Attached are two patches - one that always > > > canonicalizes group and user names and one that adds a new option to > > > canonicalize from cache. > > > > > > Patch 0001: > > Ack > > > > Patch 0002: Nack (minor) > > > > Please lower the debug level on the cache-miss for sysdb_get*id(). It's > > going to be fairly common and SSSDBG_MINOR_FAILURE is too noisy. Use > > SSSDBG_TRACE_FUNC instead. > > > > > > Right, fixed patches are attached. Ack