URL: https://github.com/SSSD/sssd/pull/78 Author: mzidek-rh Title: #78: ipa: Nested netgroups do not work Action: opened
PR body: """ We lowercase the keys to the hash table used to store netgroups but do not lowercase it when reading the table. This results in nested netgroups not being found when they should and the processing fails.
The lowercasing does not seem to be necessary anymore (not sure if it ever was) so we can skip it.
Resolves: https://fedorahosted.org/sssd/ticket/3159 """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/78/head:pr78 git checkout pr78
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
jhrozek commented: """ btw just to help with the review, I also fired up a test job using our downstream tests with a 7.3 package and this test. I'll let you know how the test went. """
See the full comment at https://github.com/SSSD/sssd/pull/78#issuecomment-259912952
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
celestian commented: """ Code LGTM. CI passed: http://sssd-ci.duckdns.org/logs/job/56/99/summary.html
And I tested it manually: ``` Setup FreeIPA server and do the following: 1. create two netgroups - ng1, ng2 2. add user1 to ng1 3. add user2 to ng2 4. add ng2 to ng1 (make ng2 member of ng1) 5. run command: $ getent netgroup ng1
Wrong output: you do not see netgroup members Correct output: You shoudl see all members of ng1 and ng2 ```
@jhrozek , I give conitional ACK to this patch if downstream tests passed. """
See the full comment at https://github.com/SSSD/sssd/pull/78#issuecomment-259938864
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
jhrozek commented: """ The downstream tests passed (the job ID is 1594128 if anyone wants to take a look).
So I'm adding the Accepted tag. """
See the full comment at https://github.com/SSSD/sssd/pull/78#issuecomment-260324584
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
jhrozek commented: """ master: ff565da1011aa4312847e28e7af66e57fccf8b90 sssd-1-14: 7de33877c7e39f9a5cae6baf815dc18ae5a18597 sssd-1-13: 9c4c3a204e1631f61378982d39cdba0ce25ee262 """
See the full comment at https://github.com/SSSD/sssd/pull/78#issuecomment-260345094
URL: https://github.com/SSSD/sssd/pull/78 Author: mzidek-rh Title: #78: ipa: Nested netgroups do not work Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/78/head:pr78 git checkout pr78
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/78 Title: #78: ipa: Nested netgroups do not work
Label: +Pushed
sssd-devel@lists.fedorahosted.org
-
fidencio