URL: https://github.com/SSSD/sssd/pull/196 Author: mzidek-rh Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing Action: synchronized

To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/196/head:pr196 git checkout pr196

URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing

lslebodn commented: """ On (15/03/17 07:53), mzidek-rh wrote:

I just realized that the message needs to be printed conditionally only if SSSD was configured with --enable-files-domain . I tested it in both cases. Also no longer use the word "generated", because as Lukas mentioned it is not really what is happening.

That woudl be OK; BUT .. (not related to your patch)

man page sssd.conf says (XML version): ``` <term>enable_files_domain (boolean)</term> <listitem> <para> When this option is enabled, SSSD prepends an implicit domain with <quote>id_provider=files</quote> before any explicitly configured domains. </para> <para condition="no_enable_files_domain"> Default: false </para> <para condition="enable_files_domain"> Default: true </para>

```

According to man page `#ifdef ADD_FILES_DOMAIN` should just prepend implicit files domains. It should not be related to missing sssd.conf

IMHO we should fix missing sssd.conf with --disable-files-domain because `libsss_files.so` is build every time.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/196#issuecomment-286774370

URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing

lslebodn commented: """ On (15/03/17 09:45), mzidek-rh wrote:

Sorry, I do not understand your last comment. Can you please summarize it in an pagure issue? I am little bit confused (but if I understand it correctly it does not affect the PR, right?)

I did not update the patches, please tell me if you think I should.

IMHO; it depends on https://pagure.io/SSSD/sssd/issue/3340 https://pagure.io/SSSD/sssd/issue/3339

Because message might change after fixing these tickets.

LS

"""

See the full comment at https://github.com/SSSD/sssd/pull/196#issuecomment-287044495

URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing

lslebodn commented: """ master: * 955574eeb3a3b937abc3df150e9bbbb79b75c889

sssd-1-14: * b35d7aa90b18ba544ba11fcabeb9662e38fb91fa """

See the full comment at https://github.com/SSSD/sssd/pull/196#issuecomment-292969976

URL: https://github.com/SSSD/sssd/pull/196 Title: #196: SSSD-1.15 - config-check: Message when sssd.conf is missing

Label: +Pushed