7:06 a.m.
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: opened
PR body:
"""
Once object is in cache it is refreshed when it is expired and
requested by the system. Object ID is not checked before refresh,
but config parameter ldap_(min|max)_id could be changed by admin.
We should check object ID and not refresh objects outside min/max
ID interval.
Resolves:
https://pagure.io/SSSD/sssd/issue/3905
"""
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
11:02 a.m.
New subject: [sssd PR#716][synchronized] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
2:25 p.m.
New subject: [sssd PR#716][+Changes requested] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
Label: +Changes requested
1 p.m.
New subject: [sssd PR#716][synchronized] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
4:22 a.m.
New subject: [sssd PR#716][synchronized] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
6:41 a.m.
New subject: [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
jhrozek commented:
"""
I think this commit is mostly good. I'll just leave some very minor nitpics inline
using the github review tool.
"""
See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-452284643
8:18 a.m.
New subject: [sssd PR#716][synchronized] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: synchronized
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
9:20 a.m.
New subject: [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
thalman commented:
"""
@jhrozek I fixed all minor comments. There is still question whether we move the check as
you suggested.
"""
See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-452335917
2:56 a.m.
New subject: [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
pbrezina commented:
"""
I re-run the tests, it passed ok this time. It seems that it was not able to contact some
dnf repository.
"""
See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-453437416
3:37 a.m.
New subject: [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
sumit-bose commented:
"""
retest this please
"""
See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-493372143
2:01 p.m.
New subject: [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
jhrozek commented:
"""
Internal CI passed except Debian -> Approved
"""
See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-508217959
2:01 p.m.
New subject: [sssd PR#716][+Accepted] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
Label: +Accepted
3:13 p.m.
New subject: [sssd PR#716][comment] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
jhrozek commented:
"""
* master: d2adfcf54c3a37aeda675aec3ba3d174061fac1a
"""
See the full comment at https://github.com/SSSD/sssd/pull/716#issuecomment-508239116
3:13 p.m.
New subject: [sssd PR#716][closed] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Author: thalman
Title: #716: CACHE: SSSD doesn't clear cache entries
Action: closed
To pull the PR as Git branch:
git remote add ghsssd https://github.com/SSSD/sssd
git fetch ghsssd pull/716/head:pr716
git checkout pr716
3:17 p.m.
New subject: [sssd PR#716][+Pushed] CACHE: SSSD doesn't clear cache entries
URL: https://github.com/SSSD/sssd/pull/716
Title: #716: CACHE: SSSD doesn't clear cache entries
Label: +Pushed
1789
days inactive
1987
days old
sssd-devel@lists.fedorahosted.org
14 comments
4 participants
participants (4)
-
jhrozek -
pbrezina
-
sumit-bose
-
thalman