URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding paython-requests to dependencies Action: opened
PR body: """ Resolves: https://pagure.io/SSSD/sssd/issue/3353
Note: I am not sure if this is the correct dependency which we were looking for. But it is needed anyway. If we need more don't hesitate to write me. """
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding paython-requests to dependencies
lslebodn commented: """ It does not work for me: ``` sh$ rpm -q python-requests python2-requests python3-requests package python-requests is not installed python2-requests-2.13.0-1.fc26.noarch python3-requests-2.13.0-1.fc26.noarch ```
``` checking for CMOCKA... yes checking for uid_wrapper... yes checking for nss_wrapper... yes configure: error: cannot enable integration tests: python-requests not found make: *** [Makefile:33181: intgcheck-prepare] Error 1 ``` """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-290390906
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding paython-requests to dependencies
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding paython-requests to dependencies Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-kdc to dependencies Action: edited
Changed field: title Original value: """ TEST: Adding paython-requests to dependencies """
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-kdc to dependencies Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-libs to dependencies Action: edited
Changed field: title Original value: """ TEST: Adding krb5-kdc to dependencies """
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
celestian commented: """ I see ``` install-deps: success 00:01:07 ci-install-deps.log autoreconf: success 00:00:34 ci-autoreconf.log DEBUG BUILD: ci-build-debug configure: failure 00:00:22 ci-build-debug/ci-configure.log FAILURE ``` Is it possible to see logs?
Respectively, I tried to run the tests in our CI, but connection failed: ``` $ git push ci HEAD:master ssh_exchange_identification: Connection closed by remote host fatal: Could not read from remote repository.
Please make sure you have the correct access rights and the repository exists. ``` """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-290628112
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
lslebodn commented: """ This change does not fix anything. Fedora/el{6,7} already install kr5 in spec file `BuildRequires: krb5-devel` """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-290633378
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
lslebodn commented: """ I think that ticket 3353 is mainly about following change ``` commit 0700118d8388c38b8cb28279510b206b76a3a411 Author: Jakub Hrozek jhrozek@redhat.com Date: Tue Dec 13 17:17:16 2016 +0100
TESTS: Add integration tests for the KCM responder
diff --git a/contrib/ci/deps.sh b/contrib/ci/deps.sh index c525e62e8..4467e117c 100644 --- a/contrib/ci/deps.sh +++ b/contrib/ci/deps.sh @@ -47,6 +47,8 @@ if [[ "$DISTRO_BRANCH" == -redhat-* ]]; then uid_wrapper python-requests curl-devel + krb5-server + krb5-workstation ) _DEPS_LIST_SPEC=` sed -e 's/@PACKAGE_VERSION@/0/g' \ ```
And it would be to check which binaries are used in added python files: src/tests/intg/kdc.py, src/tests/intg/krb5utils.py, src/tests/intg/test_kcm.py
From top of my head: `kinit`
"""
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-290647051
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-libs to dependencies Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
celestian commented: """ @lslebodn thanks. I think I see it now. New patch pushed. """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-290671916
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-libs to dependencies Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
lslebodn commented: """ configure failed in intgcheck due to following error: ``` configure: error: cannot enable integration tests: krb5kdc not found ``` But `krb5kdc` was installed on system. But `/usr/sbin` was not probably in PATH.
http://sssd-ci.duckdns.org/logs/job/67/49/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-293581981
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-libs to dependencies Action: synchronized
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
fidencio commented: """ I have updated @celestian's patches in a way that sbin is also included in the PATH in our CI. """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-330824408
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
Label: -Changes requested
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
fidencio commented: """ CI: http://vm-058-233.$%7Babc%7D/logs/job/77/95/summary.html """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-330825842
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
jhrozek commented: """ LGTM """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-331258743
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
Label: +Accepted
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
Label: -Accepted
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
Label: +Changes requested
URL: https://github.com/SSSD/sssd/pull/218 Title: #218: TEST: Adding krb5-libs to dependencies
jhrozek commented: """ Since it's unlikely that anyone will revive this PR anytime soon, let's just close it. If there are developers interested in re-submitting the work, please do so with proper attribution in a new PR. """
See the full comment at https://github.com/SSSD/sssd/pull/218#issuecomment-334488209
URL: https://github.com/SSSD/sssd/pull/218 Author: celestian Title: #218: TEST: Adding krb5-libs to dependencies Action: closed
To pull the PR as Git branch: git remote add ghsssd https://github.com/SSSD/sssd git fetch ghsssd pull/218/head:pr218 git checkout pr218
sssd-devel@lists.fedorahosted.org