On 04/07/2015 02:41 PM, Pavel Březina wrote:

On 04/03/2015 05:31 PM, Pavel Reichl wrote:

...

On 04/03/2015 01:16 PM, Pavel Březina wrote:

...

https://fedorahosted.org/sssd/ticket/2611

---

sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Hello Pavel,

you patch LGTM and ci passed, but my tests failed:

1. enable enumeration
2. set ldap_enumeration_refresh_timeout to something lower than default
3. enter break-point into sdap_get_users_send()
4. wait for ldap_enumeration_refresh_timeout seconds then continue
5. segfault should happen

If I apply on top of your patch my attached patch the test passes, would you consider squeezing my patch into yours?

Thanks!

Thanks, squashed.

Great, thanks. But now I guess somebody else must do the review as we both changed the code.

---

sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

On 04/07/2015 02:47 PM, Jakub Hrozek wrote:

On Tue, Apr 07, 2015 at 02:46:06PM +0200, Pavel Reichl wrote:

...

On 04/07/2015 02:41 PM, Pavel Březina wrote:

...

On 04/03/2015 05:31 PM, Pavel Reichl wrote:

...

On 04/03/2015 01:16 PM, Pavel Březina wrote:

...

https://fedorahosted.org/sssd/ticket/2611

---

sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

Hello Pavel,

you patch LGTM and ci passed, but my tests failed:

1. enable enumeration
2. set ldap_enumeration_refresh_timeout to something lower than default
3. enter break-point into sdap_get_users_send()
4. wait for ldap_enumeration_refresh_timeout seconds then continue
5. segfault should happen

If I apply on top of your patch my attached patch the test passes, would you consider squeezing my patch into yours?

Thanks!

Thanks, squashed.

Great, thanks. But now I guess somebody else must do the review as we both changed the code.

Pavel agreed to your changed, just ack/nack the result. _______________________________________________ sssd-devel mailing list sssd-devel@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/sssd-devel

ACK, ci passed: http://sssd-ci.duckdns.org/logs/job/12/55/summary.html