The short answer is no, we cannot drop support for ansible 2.8 yet (upstream, it is still marked as maintained for security fixes, which means we should still support it; downstream for Red Hat customers, we will still be supporting 2.8 for the foreseeable future). That being said - let's see if we can fix your problems - see below On 10/24/20 2:32 AM, Gris Ge wrote: Hi, According to [ansible lifecyle][1], the ansible 2.8 is security fixes only. And ansible 2.8 already breaks our CI on Fedora 32 when trying to collect service facts: https://github.com/ansible/ansible/issues/69302 I thought we had some sort of workaround for this? Perhaps Till remembers?

Meanwhile, due to lacking of support relative import, the files in `modules_utils` are required to use: from ansible.module_utils.xxx.error import LsrNetworkNmError Instead of: from .error import LsrNetworkNmError Is that an ansible 2.8 issue or a python 2.x issue? Lacking of relative import also requires a lot hack to our unit tests. How so? Hence I would like to suggest we drop the support of ansible 2.8. Any ideas? [1]: https://docs.ansible.com/ansible/devel/reference_appendices/release_and_m... _______________________________________________ systemroles mailing list -- systemroles(a)lists.fedorahosted.org To unsubscribe send an email to systemroles-leave(a)lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/systemroles@lists.fedorahost... _______________________________________________ systemroles mailing list -- systemroles(a)lists.fedorahosted.org To unsubscribe send an email to systemroles-leave(a)lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/systemroles@lists.fedorahost...

> > Meanwhile, due to lacking of support relative import, the files > in `modules_utils` are required to use: > > from ansible.module_utils.xxx.error import LsrNetworkNmError > > Instead of: > > from .error import LsrNetworkNmError Is that an ansible 2.8 issue or a python 2.x issue?

> > Lacking of relative import also requires a lot hack to our unit tests. How so?

On 10/27/20 8:53 AM, Gris Ge wrote: > On Mon, Oct 26, 2020 at 12:28:42PM -0600, Rich Megginson wrote: >>> Meanwhile, due to lacking of support relative import, the files >>> in `modules_utils` are required to use: >>> >>> from ansible.module_utils.xxx.error import LsrNetworkNmError >>> >>> Instead of: >>> >>> from .error import LsrNetworkNmError >> Is that an ansible 2.8 issue or a python 2.x issue? > Ansible 2.8. The Ansible 2.9 document confirmed relative import: > > https://docs.ansible.com/ansible/devel/porting_guides/porting_guide_2.9.h... > >>> Lacking of relative import also requires a lot hack to our unit tests. >> How so? > sys.modules["ansible"] = mock.Mock() > sys.modules["ansible.module_utils.basic"] = mock.Mock() > sys.modules["ansible.module_utils"] = mock.Mock() > sys.modules["ansible.module_utils.network_lsr"] = __import__("network_lsr") I would suggest that the network role uses the setup_module_utils.sh script instead of having the tests rewrite the module import path. e.g. like the storage role which also uses module_utils https://github.com/linux-system-roles/storage/blob/master/.travis/config.... and the kernel_settings role https://github.com/linux-system-roles/kernel_settings/blob/master/.travis... > _______________________________________________ systemroles mailing list -- systemroles(a)lists.fedorahosted.org To unsubscribe send an email to systemroles-leave(a)lists.fedorahosted.org Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/ List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines List Archives: https://lists.fedorahosted.org/archives/list/systemroles@lists.fedorahost...

> sys.modules["ansible.module_utils.network_lsr"] = __import__("network_lsr") I would suggest that the network role uses the setup_module_utils.sh script instead of having the tests rewrite the module import path.