On Mon, 14 Mar 2022, Arnaldo Melo wrote:
On Mon, Mar 14, 2022, 2:22 PM John Kacur <jkacur(a)redhat.com> wrote:
On Mon, 14 Mar 2022, Arnaldo Melo wrote:
>
>
> On Thu, Mar 10, 2022 at 2:18 PM John Kacur <jkacur(a)redhat.com> wrote:
>
>
> On Wed, 9 Mar 2022, Leah Leshchinsky wrote:
>
> > These patches introduce a new command-line interface that provides
> > distinct subcommands for the user.
> > Through the use of argparse, users see simpler help menus and can
> > view positional and optional arguments for all tuna commands.
> > The internal implementation is also simplified by removing the
need
> > for a saved state for each iteration of parsing.
> >
> > v2 Removes unnecessary sample.py file added in previous version,
> > moves changes to show_irqs() from patch 1/3 to 3/3.
> >
> > Leah Leshchinsky (3):
> > tuna: Update command-line interface
> > tuna: Edit param variable to print full policy name
> > tuna: Remove unused functions and globals
> >
> > tuna-cmd.py | 633
++++++++++++++++++++-------------------------------
> > tuna/tuna.py | 7 +-
> > 2 files changed, 246 insertions(+), 394 deletions(-)
> >
>
> This is a welcome change, thanks!
>
> Some initial comments from running this without looking at the code.
>
> /tuna-cmd.py -h
> usage: tuna-cmd.py [-h] [-v]
>
> {isolate,include,move,spread,priority,run,save,apply,show,what_is,gui}
> ...
>
> tuna - Application Tuning GUI
>
>
> I'd remove the "GUI" from the CLI help.
>
> One question, scripts written using the previous interface will continue
working? I.e. is this new CLI interface opt-in and backwards compatible?
>
> - Arnaldo
>
We were considering this to be a replacement - note it hasn't been applied
yet, it's in a proof of concept state. Do you have a lot of scripts using
old tuna?
Me? No, I don't, but since this CLI is out and available for so long, you can't
know for sure.
Therefore it's not a good idea to break backwards compatibility.
I haven't looked at the reasons behind this new interface, why is this being
considered?
- Arnaldo
Time marches on, computer interfaces change, this how it works.
We believe these changes will make tuna easier to work with for the end
user and easier to maintain for programmers. Programs that don't change
just end up bit-rotting and becoming obsolete.
Wait until Leah is done with her work, and then have a look and see what
you think.
John