3:38 a.m.
Tuna showing traceback when user haven't set DISPLAY variable and using CLI with param
-l.
This is caused by gtk library which try create "window", but in CLI mode is not
neccesary.
Patch remove unnecesary library which cause this problem
Signed-off-by: Petr Oros <poros(a)redhat.com>
---
tuna/config.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tuna/config.py b/tuna/config.py
index e446447..77cc4d8 100644
--- a/tuna/config.py
+++ b/tuna/config.py
@@ -1,5 +1,5 @@
import io, os, re, fnmatch
-import sys, gtk, pygtk
+import sys, pygtk
import codecs, ConfigParser
from time import localtime, strftime
from subprocess import Popen, PIPE, STDOUT, call
--
1.8.4.2
3:38 a.m.
New subject: [PATCH v3 2/2] CLI: fix traceback where enter -p policy without prio
Tuna throwing value error when not specified priority.
Example: tuna -t PID_OF_SOME_PROCESS -p OTHER
Here "other" not priority, but scheduler policy.
For RR and FIFO default 1. For OTHER and BATCH default 0.
After patch apply, tuna use first part of string as policy and remaining part as
priority.
All unacceptable values cause exception in schedutils library and tuna show error
Signed-off-by: Petr Oros <poros(a)redhat.com>
---
tuna/tuna.py | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tuna/tuna.py b/tuna/tuna.py
index 6dfe740..0feb521 100755
--- a/tuna/tuna.py
+++ b/tuna/tuna.py
@@ -490,10 +490,14 @@ def thread_set_priority(tid, policy, rtprio):
def threads_set_priority(tids, parm, affect_children = False):
parms = parm.split(":")
+ rtprio = 0
policy = None
- if len(parms) != 1:
+ if parms[0].upper() in ["OTHER", "BATCH", "IDLE",
"FIFO", "RR"]:
policy = schedutils.schedfromstr("SCHED_%s" % parms[0].upper())
- rtprio = int(parms[1])
+ if len(parms) > 1:
+ rtprio = int(parms[1])
+ elif parms[0].upper() in ["FIFO", "RR"]:
+ rtprio = 1
else:
rtprio = int(parms[0])
--
1.8.4.2
5:24 a.m.
New subject: [PATCH v3 2/2] CLI: fix traceback where enter -p policy without prio
tested, looks ok for me too.
j.
On Wed, Dec 04, 2013 at 10:38:41AM +0100, Petr Oros wrote:
Tuna throwing value error when not specified priority.
Example: tuna -t PID_OF_SOME_PROCESS -p OTHER
Here "other" not priority, but scheduler policy.
For RR and FIFO default 1. For OTHER and BATCH default 0.
After patch apply, tuna use first part of string as policy and remaining part as
priority.
All unacceptable values cause exception in schedutils library and tuna show error
Signed-off-by: Petr Oros <poros(a)redhat.com>
---
tuna/tuna.py | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/tuna/tuna.py b/tuna/tuna.py
index 6dfe740..0feb521 100755
--- a/tuna/tuna.py
+++ b/tuna/tuna.py
@@ -490,10 +490,14 @@ def thread_set_priority(tid, policy, rtprio):
def threads_set_priority(tids, parm, affect_children = False):
parms = parm.split(":")
+ rtprio = 0
policy = None
- if len(parms) != 1:
+ if parms[0].upper() in ["OTHER", "BATCH", "IDLE",
"FIFO", "RR"]:
policy = schedutils.schedfromstr("SCHED_%s" % parms[0].upper())
- rtprio = int(parms[1])
+ if len(parms) > 1:
+ rtprio = int(parms[1])
+ elif parms[0].upper() in ["FIFO", "RR"]:
+ rtprio = 1
else:
rtprio = int(parms[0])
--
1.8.4.2
_______________________________________________
tuna-devel mailing list
tuna-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
5:23 a.m.
tested, looks ok for me.
j.
On Wed, Dec 04, 2013 at 10:38:40AM +0100, Petr Oros wrote:
Tuna showing traceback when user haven't set DISPLAY variable and
using CLI with param -l.
This is caused by gtk library which try create "window", but in CLI mode is not
neccesary.
Patch remove unnecesary library which cause this problem
Signed-off-by: Petr Oros <poros(a)redhat.com>
---
tuna/config.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tuna/config.py b/tuna/config.py
index e446447..77cc4d8 100644
--- a/tuna/config.py
+++ b/tuna/config.py
@@ -1,5 +1,5 @@
import io, os, re, fnmatch
-import sys, gtk, pygtk
+import sys, pygtk
import codecs, ConfigParser
from time import localtime, strftime
from subprocess import Popen, PIPE, STDOUT, call
--
1.8.4.2
_______________________________________________
tuna-devel mailing list
tuna-devel(a)lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/tuna-devel
3737
days inactive
3794
days old
tuna-devel@lists.fedorahosted.org
3 comments
2 participants
participants (2)
-
Jiri Kastner -
Petr Oros