In tuna-cmd.py, if a thread list is passed along with the '--priority' flag, tuna.get_policy_and_rtprio() is called twice, first directly, and then again by tuna.threads_set_priority(). The expectation is that tuna.threads_set_priority will handle exceptions raised by tuna.get_policy_and_rtprio(). This results in a failure to handle exceptions that are raised by the initial direct call to tuna.get_policy_and_rtprio(). Handle exceptions that may be raised during direct calls to get_policy_and_rtprio in tuna-cmd.py. Signed-off-by: Leah Leshchinsky <lleshchi(a)redhat.com&gt; diff --git a/tuna-cmd.py b/tuna-cmd.py index cf117ec046ff..2b6e91bd0104 100755 --- a/tuna-cmd.py +++ b/tuna-cmd.py @@ -601,7 +601,11 @@ def main(): tuna.include_cpus(cpu_list, get_nr_cpus()) elif o in ("-p", "--priority"): # Save policy and rtprio for future Actions (e.g. --run). - (policy, rtprio) = tuna.get_policy_and_rtprio(a) + try: + (policy, rtprio) = tuna.get_policy_and_rtprio(a) + except ValueError: + print("tuna: " + _("\"%s\" is an unsupported priority value!") % a) + sys.exit(2) if not thread_list: # For backward compatibility p_waiting_action = True --

Variable 'parms' should be 'parm'. Fix typo. Signed-off-by: Leah Leshchinsky <lleshchi(a)redhat.com&gt; diff --git a/tuna/tuna.py b/tuna/tuna.py index 8fb42121e2e4..126990339985 100755 --- a/tuna/tuna.py +++ b/tuna/tuna.py @@ -561,7 +561,7 @@ def threads_set_priority(tids, parm, affect_children=False): try: (policy, rtprio) = get_policy_and_rtprio(parm) except ValueError: - print("tuna: " + _("\"%s\" is unsupported priority value!") % parms[0]) + print("tuna: " + _("\"%s\" is an unsupported priority value!") % parm[0]) return for tid in tids: --