Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
......................................................................
Patch Set 3: Code-Review+1 Verified+1
copying scores after nit fix
--
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda <godas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chapligin <akashihi(a)gmail.com>
Gerrit-Reviewer: Gobinda <godas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 7 months
Change in vdsm[master]: Enabled selinux boolean virt_use_glusterd for glusterd
by Code Review
From Yaniv Bronhaim <ybronhei(a)redhat.com>:
Yaniv Bronhaim has posted comments on this change.
Change subject: Enabled selinux boolean virt_use_glusterd for glusterd
......................................................................
Patch Set 2: Code-Review+1
--
To view, visit https://gerrit.ovirt.org/81088
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia92a0c43ba2b149597a2321328ca1506f4dddf12
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Gobinda <godas(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Denis Chapligin <akashihi(a)gmail.com>
Gerrit-Reviewer: Gobinda <godas(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 7 months
Change in vdsm[master]: [wip] fix vmdevices.storage.makeName
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has uploaded a new change for review.
Change subject: [wip] fix vmdevices.storage.makeName
......................................................................
[wip] fix vmdevices.storage.makeName
it should mimic http://elixir.free-electrons.com/linux/latest/ident/sd_format_disk_name
Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Signed-off-by: Dan Kenigsberg <danken(a)redhat.com>
---
M lib/vdsm/virt/vmdevices/storage.py
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/55/81155/1
diff --git a/lib/vdsm/virt/vmdevices/storage.py b/lib/vdsm/virt/vmdevices/storage.py
index a67d4f8..f34deb7 100644
--- a/lib/vdsm/virt/vmdevices/storage.py
+++ b/lib/vdsm/virt/vmdevices/storage.py
@@ -806,8 +806,10 @@
devindex = ''
i = int(index)
- while i > 0:
+ while True:
devindex = chr(ord('a') + (i % 26)) + devindex
- i //= 26
+ i = i // 26 - 1
+ if i < 0:
+ break
return devname.get(interface, 'hd') + (devindex or 'a')
--
To view, visit https://gerrit.ovirt.org/81155
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib0219be59e408df6628fd148b9ad70af8e2366aa
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
6 years, 7 months
Change in vdsm[master]: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Hello Jenkins CI, gerrit-hooks, Irit Goihman, Edward Haas,
I'd like you to do a code review. Please visit
https://gerrit.ovirt.org/81150
to review the following change.
Change subject: Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
......................................................................
Revert "dpdk: add only non dpdk nics to aqcuired ifaces"
This reverts commit 936e6cc89aec8fb6a5894382ea1a349979c3fc06.
Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
---
M lib/vdsm/network/ovs/switch.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/50/81150/1
diff --git a/lib/vdsm/network/ovs/switch.py b/lib/vdsm/network/ovs/switch.py
index 64930c9..cff51b9 100644
--- a/lib/vdsm/network/ovs/switch.py
+++ b/lib/vdsm/network/ovs/switch.py
@@ -124,8 +124,7 @@
nic = attrs.get('nic')
bond = attrs.get('bonding')
sb = nic or bond
- if not dpdk.is_dpdk(sb):
- self._acquired_ifaces.add(sb)
+ self._acquired_ifaces.add(sb)
bridge = self._get_ovs_bridge(sb)
self._create_nb(bridge, net)
--
To view, visit https://gerrit.ovirt.org/81150
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica5e7ca429b9a83a97cb9017c163f713ce762853
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in vdsm[master]: move sitecustomize to static
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80859 )
Change subject: move sitecustomize to static
......................................................................
move sitecustomize to static
Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Signed-off-by: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
---
M Makefile.am
M static/Makefile.am
R static/usr/share/vdsm/sitecustomize.py
M tests/run_tests_local.sh.in
M vdsm/Makefile.am
5 files changed, 6 insertions(+), 8 deletions(-)
Approvals:
Piotr Kliczewski: Verified
Jenkins CI: Passed CI tests
Dan Kenigsberg: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in vdsm[master]: move sitecustomize to static
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move sitecustomize to static
......................................................................
Patch Set 7: Code-Review+2
--
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 7 months
Change in vdsm[master]: ovs-dpdk: support ovs 2.7
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80818 )
Change subject: ovs-dpdk: support ovs 2.7
......................................................................
ovs-dpdk: support ovs 2.7
Compatibility with the old dpdk<portid> naming is broken in ovs 2.7, and as
such a device will not be available for use until a valid dpdk-devargs is
specified.
When adding dpdk devices to ovs bridge, the PCI address must be
set using the 'dpdk-devargs' option.
Device naming is arbitrary.
Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Signed-off-by: Irit Goihman <igoihman(a)redhat.com>
---
M lib/vdsm/network/link/dpdk.py
M lib/vdsm/network/ovs/driver/__init__.py
M lib/vdsm/network/ovs/driver/vsctl.py
M lib/vdsm/network/ovs/switch.py
M vdsm.spec.in
5 files changed, 15 insertions(+), 4 deletions(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Verified
Edward Haas: Looks good to me, approved
--
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in vdsm[master]: ovs-dpdk: support ovs 2.7
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: ovs-dpdk: support ovs 2.7
......................................................................
Patch Set 7:
unrelated failure
ERROR: test_with_device (loopback_test.TestDevice)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/testValidation.py", line 191, in wrapper
return f(*args, **kwargs)
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback_test.py", line 42, in test_with_device
with loopback.Device(filename) as device:
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py", line 92, in __enter__
self.attach()
File "/home/jenkins/workspace/vdsm_master_check-patch-el7-x86_64/vdsm/tests/loopback.py", line 56, in attach
raise cmdutils.Error(cmd, rc, out, err)
Error: Command ['losetup', '--find', '--show', '/tmp/tmpzf6_TD/file'] failed with rc=1 out='' err='losetup: /tmp/tmpzf6_TD/file: failed to set up loop device: No such file or directory\n'
--
To view, visit https://gerrit.ovirt.org/80818
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If4c2601c93a33adba43b0d324ab5186f5505f6aa
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No
6 years, 7 months
Change in vdsm[master]: automation: Fix - Add iproute-tc package to fc25
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has submitted this change and it was merged. ( https://gerrit.ovirt.org/80819 )
Change subject: automation: Fix - Add iproute-tc package to fc25
......................................................................
automation: Fix - Add iproute-tc package to fc25
On recent fedora25, the tc tool has been extracted out of iproute
package and moved to its own package.
This package is now added as a VDSM dependency (used by
vdsm-networking for QoS).
This patch fixes an older patch where the dependency has not been
correctly added to the spec file:
e23586b6d9c913786b06ec063649c8eb56d73a49
Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Signed-off-by: Edward Haas <edwardh(a)redhat.com>
---
M vdsm.spec.in
1 file changed, 3 insertions(+), 1 deletion(-)
Approvals:
Jenkins CI: Passed CI tests
Irit Goihman: Looks good to me, but someone else must approve
Dan Kenigsberg: Looks good to me, approved
Edward Haas: Verified
--
To view, visit https://gerrit.ovirt.org/80819
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic9727109fcc7171811057d9a8327c3dc2b20495e
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
6 years, 7 months
Change in vdsm[master]: move sitecustomize to static
by Code Review
From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: move sitecustomize to static
......................................................................
Patch Set 6: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/80859/6/tests/run_tests_local.sh.in
File tests/run_tests_local.sh.in:
PS6, Line 21: @top_srcdir@/vdsm
I think that this should be dropped. nothing is left there.
--
To view, visit https://gerrit.ovirt.org/80859
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4fead076a4891f42985672da6e67d5d738b8c482
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes
6 years, 7 months