On Tue, Sep 10, 2019 at 6:57 PM Dridi Boukelmoune
<dridi.boukelmoune@gmail.com> wrote:
>
> > How about a copr? they now have discourse threads for builds which could
> > be a way to collect feedback?
>
> https://copr.fedorainfracloud.org/coprs/dridi/xfwm4/

I got curious and wondered how hard it would be to apply my
development workflow for testing and hook copr instead, and it was
only a one-liner that I needed to start testing.

That didn't work however. If anyone tried to follow the instructions I
expect it fell short the moment Window Manager Tweaks showed up.
After some digging it turns out the feature was properly there and
accessible from the settings editor (cycle_primary_monitor) but the
Tweaks UI wasn't updated. After further digging it turns out patches
to the XML user interfaces are as good as no-ops when you build from
a "dist" archive. It didn't take me long to figure that I needed an extra
dependency to support the --enable-maintainer-mode at %configure
time.

My current full spec diff on copr:

> @@ -2,7 +2,7 @@
>
>  Name:           xfwm4
>  Version:        4.14.0
> -Release:        1%{?dist}
> +Release:        202%{?dist}
>  Summary:        Next generation window manager for Xfce
>
>  License:        GPLv2+
> @@ -27,6 +27,10 @@ BuildRequires:  desktop-file-utils
>
>  Provides:       firstboot(windowmanager) = xfwm4
>
> +BuildRequires:  xfce4-dev-tools
> +Patch0:         0001-common-Add-a-xfwm_monitor_is_primary-function.patch
> +Patch1:         0002-tabwin-New-tweak-to-only-show-on-the-primary-monitor.patch
> +
>  %description
>  xfwm4 is a window manager compatible with GNOME, GNOME2, KDE2, KDE3 and Xfce.
>
> @@ -35,7 +39,7 @@ xfwm4 is a window manager compatible with GNOME, GNOME2, KDE2, KDE3 and Xfce.
>
>
>  %build
> -%configure  --disable-static
> +%configure --disable-static --enable-maintainer-mode
>
>  %make_build

In summary:

- xfwm4-4.14.0-201: feature present and visible in settings editor
- xfwm4-4.14.0-202: feature present and visible in Window Manager Tweaks

Apologies for the inconvenience, Kevin "forced" me to refresh my copr
knowledge and dig deeper in xfwm4 :)




Dridi
_______________________________________________
xfce mailing list -- xfce@lists.fedoraproject.org
To unsubscribe send an email to xfce-leave@lists.fedoraproject.org
Fedora Code of Conduct: https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives: https://lists.fedoraproject.org/archives/list/xfce@lists.fedoraproject.org