4:43 a.m.
Greetings fellow Xfce users,
I'm overall very happy with my favorite spin, except for that one
detail I finally decided to tackle myself. Which I surprisingly did
without too much difficulty, and I sent my patches upstream:
https://bugzilla.xfce.org/show_bug.cgi?id=15942
My question is the following: could it be possible to create a bodhi
update for f30 for testing purposes only? Not an update that we'd
push to stable.
I would like at least some feedback beyond that "it works on my
machine", and posting the link to the bodhi update in the upstream
ticket could maybe help speed things up. At the very least I'm rather
confident because the change is very simple, but it would be better
to find problems sooner.
This adds a new tweak to the xfwm4 window manager to only show
the cycling window (alt+tab window) on the primary monitor. So ideally
that would mean testing with both a single monitor and several of them
(I could only try 1 and 2 monitors myself).
If anyone is interested I can share how I set things up to work on a
window manager (I have never done that before, and it didn't even
take long).
Thanks,
Dridi
4:51 a.m.
On 9/10/19 5:43 AM, Dridi Boukelmoune wrote:
Greetings fellow Xfce users,
I'm overall very happy with my favorite spin, except for that one
detail I finally decided to tackle myself. Which I surprisingly did
without too much difficulty, and I sent my patches upstream:
https://bugzilla.xfce.org/show_bug.cgi?id=15942
My question is the following: could it be possible to create a bodhi
update for f30 for testing purposes only? Not an update that we'd
push to stable.
I would like at least some feedback beyond that "it works on my
machine", and posting the link to the bodhi update in the upstream
ticket could maybe help speed things up. At the very least I'm rather
confident because the change is very simple, but it would be better
to find problems sooner.
This adds a new tweak to the xfwm4 window manager to only show
the cycling window (alt+tab window) on the primary monitor. So ideally
that would mean testing with both a single monitor and several of them
(I could only try 1 and 2 monitors myself).
If anyone is interested I can share how I set things up to work on a
window manager (I have never done that before, and it didn't even
take long).
Thanks,
Dridi
I can build this and send this list a koji link (instead of bodhi -
which we still can if needed). I'll get a build this evening after work.
4:57 a.m.
I can build this and send this list a koji link (instead of bodhi -
which we still can if needed). I'll get a build this evening after work.
The reason why I asked for a bodhi update was to get feedback in a
single place that I could either work on to fix problems or link in
upstream's ticket if all the feedback is positive. I could do a scratch
build myself, and actually would if bodhi is not an option.
Thanks for the fast response!
Dridi
11:58 a.m.
On 9/10/19 2:57 AM, Dridi Boukelmoune wrote:
> I can build this and send this list a koji link (instead of bodhi
-
> which we still can if needed). I'll get a build this evening after work.
The reason why I asked for a bodhi update was to get feedback in a
single place that I could either work on to fix problems or link in
upstream's ticket if all the feedback is positive. I could do a scratch
build myself, and actually would if bodhi is not an option.
Thanks for the fast response!
How about a copr? they now have discourse threads for builds which could
be a way to collect feedback?
kevin
1:57 p.m.
How about a copr? they now have discourse threads for builds which
could
be a way to collect feedback?
https://copr.fedorainfracloud.org/coprs/dridi/xfwm4/
How embarrassing, I forgot about copr... It has grown beyond Fedora, like mock!
Anyway, I used the installation instructions to explain how to test
the change, and the spec is the same as current f30/rawhide with the 2
patches I submitted upstream.
Thanks again for the suggestions and quick replies!
Dridi
5:34 p.m.
On Tue, Sep 10, 2019 at 6:57 PM Dridi Boukelmoune
<dridi.boukelmoune(a)gmail.com> wrote:
> How about a copr? they now have discourse threads for builds which could
> be a way to collect feedback?
https://copr.fedorainfracloud.org/coprs/dridi/xfwm4/
I got curious and wondered how hard it would be to apply my
development workflow for testing and hook copr instead, and it was
only a one-liner that I needed to start testing.
That didn't work however. If anyone tried to follow the instructions I
expect it fell short the moment Window Manager Tweaks showed up.
After some digging it turns out the feature was properly there and
accessible from the settings editor (cycle_primary_monitor) but the
Tweaks UI wasn't updated. After further digging it turns out patches
to the XML user interfaces are as good as no-ops when you build from
a "dist" archive. It didn't take me long to figure that I needed an extra
dependency to support the --enable-maintainer-mode at %configure
time.
My current full spec diff on copr:
@@ -2,7 +2,7 @@
Name: xfwm4
Version: 4.14.0
-Release: 1%{?dist}
+Release: 202%{?dist}
Summary: Next generation window manager for Xfce
License: GPLv2+
@@ -27,6 +27,10 @@ BuildRequires: desktop-file-utils
Provides: firstboot(windowmanager) = xfwm4
+BuildRequires: xfce4-dev-tools
+Patch0: 0001-common-Add-a-xfwm_monitor_is_primary-function.patch
+Patch1: 0002-tabwin-New-tweak-to-only-show-on-the-primary-monitor.patch
+
%description
xfwm4 is a window manager compatible with GNOME, GNOME2, KDE2, KDE3 and Xfce.
@@ -35,7 +39,7 @@ xfwm4 is a window manager compatible with GNOME, GNOME2, KDE2, KDE3 and
Xfce.
%build
-%configure --disable-static
+%configure --disable-static --enable-maintainer-mode
%make_build
In summary:
- xfwm4-4.14.0-201: feature present and visible in settings editor
- xfwm4-4.14.0-202: feature present and visible in Window Manager Tweaks
Apologies for the inconvenience, Kevin "forced" me to refresh my copr
knowledge and dig deeper in xfwm4 :)
Dridi
9:16 a.m.
Hi everyone,
just for future reference, you can also use the xfce-test Docker container
for quick testing.
So far we have no wiki or docs reference page about it, but the readme
should help you get started.
https://github.com/schuellerf/xfce-test
Cheers
Simon
Dridi Boukelmoune <dridi.boukelmoune(a)gmail.com> schrieb am Mi., 11. Sep.
2019, 00:35:
On Tue, Sep 10, 2019 at 6:57 PM Dridi Boukelmoune
<dridi.boukelmoune(a)gmail.com> wrote:
>
> > How about a copr? they now have discourse threads for builds which
could
> > be a way to collect feedback?
>
> https://copr.fedorainfracloud.org/coprs/dridi/xfwm4/
I got curious and wondered how hard it would be to apply my
development workflow for testing and hook copr instead, and it was
only a one-liner that I needed to start testing.
That didn't work however. If anyone tried to follow the instructions I
expect it fell short the moment Window Manager Tweaks showed up.
After some digging it turns out the feature was properly there and
accessible from the settings editor (cycle_primary_monitor) but the
Tweaks UI wasn't updated. After further digging it turns out patches
to the XML user interfaces are as good as no-ops when you build from
a "dist" archive. It didn't take me long to figure that I needed an extra
dependency to support the --enable-maintainer-mode at %configure
time.
My current full spec diff on copr:
> @@ -2,7 +2,7 @@
>
> Name: xfwm4
> Version: 4.14.0
> -Release: 1%{?dist}
> +Release: 202%{?dist}
> Summary: Next generation window manager for Xfce
>
> License: GPLv2+
> @@ -27,6 +27,10 @@ BuildRequires: desktop-file-utils
>
> Provides: firstboot(windowmanager) = xfwm4
>
> +BuildRequires: xfce4-dev-tools
> +Patch0: 0001-common-Add-a-xfwm_monitor_is_primary-function.patch
> +Patch1:
0002-tabwin-New-tweak-to-only-show-on-the-primary-monitor.patch
> +
> %description
> xfwm4 is a window manager compatible with GNOME, GNOME2, KDE2, KDE3 and
Xfce.
>
> @@ -35,7 +39,7 @@ xfwm4 is a window manager compatible with GNOME,
GNOME2, KDE2, KDE3 and Xfce.
>
>
> %build
> -%configure --disable-static
> +%configure --disable-static --enable-maintainer-mode
>
> %make_build
In summary:
- xfwm4-4.14.0-201: feature present and visible in settings editor
- xfwm4-4.14.0-202: feature present and visible in Window Manager Tweaks
Apologies for the inconvenience, Kevin "forced" me to refresh my copr
knowledge and dig deeper in xfwm4 :)
Dridi
_______________________________________________
xfce mailing list -- xfce(a)lists.fedoraproject.org
To unsubscribe send an email to xfce-leave(a)lists.fedoraproject.org
Fedora Code of Conduct:
https://docs.fedoraproject.org/en-US/project/code-of-conduct/
List Guidelines: https://fedoraproject.org/wiki/Mailing_list_guidelines
List Archives:
https://lists.fedoraproject.org/archives/list/xfce@lists.fedoraproject.org
5:07 a.m.
On Fri, Sep 13, 2019 at 2:16 PM Simon Steinbeiss <simon(a)xfce.org> wrote:
Hi everyone,
just for future reference, you can also use the xfce-test Docker container for quick
testing.
So far we have no wiki or docs reference page about it, but the readme should help you
get started.
https://github.com/schuellerf/xfce-test
I tried that but got an SELinux denial, and it also required learning
how a test is put together. So I left that for a time with more free
time on my hands, patching xfwm4 took me 2 evenings, including
giving a shot to xfce-test.
By the way the copr repo should be functional for Fedora 30. I would
be happy to have feedback on bare metal instead of a container or a
VM. Somehow the Rawhide x86_64 build failed but I couldn't reproduce
it locally with mock.
Dridi
7:54 a.m.
By the way the copr repo should be functional for Fedora 30. I would
be happy to have feedback on bare metal instead of a container or a
VM. Somehow the Rawhide x86_64 build failed but I couldn't reproduce
it locally with mock.
I tracked down the failure and this is merely a race condition in the
build system for parallel builds.
I submitted a xfwm4-4.14.0-203 build that succeeded on all selected
platforms.
Dridi
4:18 p.m.
On Mon, Sep 16, 2019 at 12:54 PM Dridi Boukelmoune
<dridi.boukelmoune(a)gmail.com> wrote:
> By the way the copr repo should be functional for Fedora 30. I would
> be happy to have feedback on bare metal instead of a container or a
> VM. Somehow the Rawhide x86_64 build failed but I couldn't reproduce
> it locally with mock.
I tracked down the failure and this is merely a race condition in the
build system for parallel builds.
I submitted a xfwm4-4.14.0-203 build that succeeded on all selected
platforms.
Greetings,
I had nothing exciting to do this evening and decided to document my
clunky workflow for my future self. Sadly, no one reached out to me to
confirm whether they could test the patches successfully, but I guess
I will patiently apply those patches downstream until maybe one day it
catches the maintainer's attention upstream. But the COPR repository
shows 10 downloads for Fedora 30 (1 from me) and 5 for Rawhide so
there's hope :)
If anyone's interested in safe Xfce hacking, my notes are now available:
https://dridi.fedorapeople.org/post/xfce-presentation-mode/
Dridi
1663
days inactive
1687
days old
9 comments
4 participants
participants (4)
-
Dridi Boukelmoune -
Kevin Fenzi -
Mukundan Ragavan -
Simon Steinbeiss