On Wed, Jan 04, 2023 at 03:04:02PM +0100, Vít Ondruch wrote:
Dne 03. 01. 23 v 19:03 Todd Zullinger napsal(a):
> Zbigniew Jędrzejewski-Szmek wrote:
>> Yes, this is what I was talking about too. Because rpmbuild does not set
>> %_sourcedir, it may fail to load some files. Even worse, it may load *wrong*
>> versions, e.g. when some old version is present in the ~/rpmbuild/SOURCES/.
>> Personally, I have dozens of stray files there from old rpm builds there…
> I've used the following in ~/.rpmmacros for many years to
> have rpmbuild keep package files together, as rpkg/fedpkg
> do:
>
> %_sourcedir %{_topdir}/%{?name:%name}
> %_specdir %{_sourcedir}
> %_builddir %{_sourcedir}
> %_srcrpmdir %{_sourcedir}
> %_rpmdir %{_sourcedir}
Change to the dist-git layout is tracked upstream [1], so maybe the
default will change one day. But shouldn't we suggest this configuration
somewhere in Fedora documentation? Maybe we could speed up the
transition ...
There is rpmdev-setuptree in the rpmdevtools package, which itself is
required by fedora-packager. It creates the following:
$ cat .rpmmacros
%_topdir %(echo $HOME)/rpmbuild
%__arch_install_post \
[ "%{buildarch}" = "noarch" ] || QA_CHECK_RPATHS=1 ; \
case "${QA_CHECK_RPATHS:-}" in [1yY]*) /usr/lib/rpm/check-rpaths ;; esac \
/usr/lib/rpm/check-buildroot
$ find rpmbuild
rpmbuild/
rpmbuild/RPMS
rpmbuild/SOURCES
rpmbuild/SPECS
rpmbuild/SRPMS
rpmbuild/BUILD
Perhaps this can be modified to create a layout that matches dist-git?