[389-commits] [389-ds-base] branch master updated: Issue 50506 - Fix regression from slapi_entry_attr_get_ref refactor

This is an automated email from the git hooks/post-receive script. mreynolds pushed a commit to branch master in repository 389-ds-base. The following commit(s) were added to refs/heads/master by this push: new e378092 Issue 50506 - Fix regression from slapi_entry_attr_get_ref refactor e378092 is described below commit e3780926368bdcdbcfac86a154e55706d3dc0c8f Author: Mark Reynolds <mreynolds(a)redhat.com&gt; AuthorDate: Fri Aug 23 11:27:27 2019 -0400 Issue 50506 - Fix regression from slapi_entry_attr_get_ref refactor Description: In pwenc.c we took a reference to the attribute value, but it was freed before we looked at it. relates: https://pagure.io/389-ds-base/issue/50506 Regviewed by: mreynolds (one line commit rule) --- ldap/servers/slapd/tools/pwenc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/ldap/servers/slapd/tools/pwenc.c b/ldap/servers/slapd/tools/pwenc.c index fe7f2a5..1629c06 100644 --- a/ldap/servers/slapd/tools/pwenc.c +++ b/ldap/servers/slapd/tools/pwenc.c @@ -362,7 +362,8 @@ slapd_config(const char *configdir, const char *givenconfigfile) } } else if (slapi_sdn_compare(&config_dn, slapi_entry_get_sdn_const(e)) == 0) { /* Get the root scheme out and initialise it (if it exists) */ - rootschemename = (char *)slapi_entry_attr_get_ref(e, CONFIG_ROOTPWSTORAGESCHEME_ATTRIBUTE); + slapi_ch_free_string(&rootschemename); + rootschemename = slapi_entry_attr_get_charptr(e, CONFIG_ROOTPWSTORAGESCHEME_ATTRIBUTE); } slapi_entry_free(e); @@ -382,6 +383,7 @@ slapd_config(const char *configdir, const char *givenconfigfile) if (rootschemename != NULL) { config_set_rootpwstoragescheme(CONFIG_ROOTPWSTORAGESCHEME_ATTRIBUTE, rootschemename, NULL, 1); + slapi_ch_free_string(&rootschemename); } slapi_ch_free_string(&buf); -- To stop receiving notification emails like this one, please contact the administrator of this repository.