[389-devel] Please review (fixing coverity issues): [389 Project] #47571: targetattr ACIs ignore subtype

https://fedorahosted.org/389/ticket/47571 https://fedorahosted.org/389/attachment/ticket/47571/0001-Ticket-47571-ta... Description: commit 85a78741dfeb636a1cf7cced1576278e65f5bb58 <https://fedorahosted.org/389/changeset/85a78741dfeb636a1cf7cced1576278e65... introduced 2 coverity issues: 12423: Explicit null dereferenced do_search (slapd/search.c) If attribute list contains multiple "*"s and "aci"s in ldapsearch, the previous code attempted to add "aci" once for "*" and replacing "aci" with normalized aci (if any) once and eliminating the duplicated "aci"s. The code contained a null dereferenced bug. Even if duplicated attributes are included in the attribute list, they are removed later in send_specific_attrs. Thus, this patch simplifies the logic to avoid the null dereference. 12422: Logically dead code comp_cmp (slapd/attr.c) Eliminated the dead code (case s1 == NULL AND s2 == NULL).