[389-devel] Please review: [Bug 506786] Index maintenance mechanism causes wrong search results when modifying attributes with subtypes

Summary: Index maintenance mechanism causes wrong search results when modifying attributes with subtypes https://bugzilla.redhat.com/show_bug.cgi?id=506786 [Problem Description] When adding a value to an attribute with subtype indexed on equality and then deleting this attribute subtype the index is not maintained correctly which results in wrong search results afterwards. After stopping the server and reindexing with db2index everything works correctly again. The unindexed and substring searches do not seem to be concerned. [Fix Description] When checking the same value exists in the entry, instead of using the type to be modified, pass the basetype. It covers the both cases removing the attribute with subtype as well as with no subtype (basetype). [Proposed Fix] Created an attachment (id=356696) --> (https://bugzilla.redhat.com/attachment.cgi?id=356696) git patch file (index.c) Thanks to Nathan for his idea to fix this problem. I verified your suggestion worked on the case that Andrey reported.