[389-devel] Re: Please review: Issue 49581 - Fix dynamic plugins test suite

Fixed the issues Viktor has reported. Please, review. On Mon, Apr 16, 2018 at 12:25:35PM +0200, Simon Pichugin wrote: > On Thu, Apr 12, 2018 at 12:17:06PM +0200, Simon Pichugin wrote: > > Hi team, > > please review a PR for dynamic plugins test suite fix. > > > > https://pagure.io/389-ds-base/issue/49581 > > https://pagure.io/389-ds-base/pull-request/49626 > > I devided it in two parts for easy review. > > > > https://pagure.io/fork/spichugi/389-ds-base/c/9c7a76e27adfff02c40abdd4d49... > > First part adds a new Plugin functionality and fixes test suite. > > > > https://pagure.io/fork/spichugi/389-ds-base/c/6da4cd78e117e0f3f75165561ca... > > And the second one moves the plugins_test.py to plugins/acceptance_test.py > > and adopts it for working with fixtures. > Small update acording to William's comments. > > > > > Later it will be rebased in one commit. > > > > Thanks, > > Simon > > _______________________________________________ > > 389-devel mailing list -- 389-devel(a)lists.fedoraproject.org > > To unsubscribe send an email to 389-devel-leave(a)lists.fedoraproject.org > _______________________________________________ > 389-devel mailing list -- 389-devel(a)lists.fedoraproject.org > To unsubscribe send an email to 389-devel-leave(a)lists.fedoraproject.org