Please review: pep8 fixes for lib389 - 389-devel - Fedora Mailing-Lists

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

Please review: pep8 fixes for lib389

Please review: Ticket #48889 -...

Idea to make replication a bit...

William Brown

Friday, 10 June 2016 Fri, 10 Jun '16

12:21 a.m.

https://fedorahosted.org/389/ticket/48878 https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

Attachments:

signature.asc (application/pgp-signature — 819 bytes)

Reply

Show replies by date

Martin Basti

Friday, 10 June Fri, 10 Jun

5:57 a.m.

On 10.06.2016 07:21, William Brown wrote:

https://fedorahosted.org/389/ticket/48878 https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... -- 389-devel mailing list 389-devel(a)lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject...

Hello, some notes if I can :) 1) This change is harder to read with PEP8 - topology.standalone.backends.create(None, - properties={ - BACKEND_NAME: NEW_BACKEND_1, - 'suffix':NEW_SUFFIX_1, - }) + topology.standalone.backends.create(None, properties={ + BACKEND_NAME: NEW_BACKEND_1, + 'suffix': NEW_SUFFIX_1, + }) ents = topology.standalone.backends.list() for ent in ents: topology.standalone.log.info("List(%d): backend %s" % I suggest to use topology.standalone.backends.create( None, properties={ BACKEND_NAME: NEW_BACKEND_1, 'suffix': NEW_SUFFIX_1, }) Same for NEW_BACKEND_2 2) I'm not sure if change in python-lib389.spec belongs to PEP8 related patch or if it is related to PEP8 Otherwise LGTM for PEP8 fixes :) Martin Basti @ IPA

Reply

William Brown

Saturday, 11 June Sat, 11 Jun

4:21 p.m.

On Fri, 2016-06-10 at 12:57 +0200, Martin Basti wrote:

On 10.06.2016 07:21, William Brown wrote: > > https://fedorahosted.org/389/ticket/48878 > > https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... > > https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... > > > > -- > 389-devel mailing list > 389-devel(a)lists.fedoraproject.org > https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject... Hello, some notes if I can :) 1) This change is harder to read with PEP8 - topology.standalone.backends.create(None, - properties={ - BACKEND_NAME: NEW_BACKEND_1, - 'suffix':NEW_SUFFIX_1, - }) + topology.standalone.backends.create(None, properties={ + BACKEND_NAME: NEW_BACKEND_1, + 'suffix': NEW_SUFFIX_1, + }) ents = topology.standalone.backends.list() for ent in ents: topology.standalone.log.info("List(%d): backend %s" % I suggest to use topology.standalone.backends.create( None, properties={ BACKEND_NAME: NEW_BACKEND_1, 'suffix': NEW_SUFFIX_1, }) Same for NEW_BACKEND_2

Done! https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-be...

2) I'm not sure if change in python-lib389.spec belongs to PEP8 related patch or if it is related to PEP8 Otherwise LGTM for PEP8 fixes :)

The idea was that basically this is a "house keeping" ticket to get ready for release. That's why I put them there. -- Sincerely, William Brown Software Engineer Red Hat, Brisbane

Reply

Martin Basti

Tuesday, 14 June Tue, 14 Jun

1:32 a.m.

On 11.06.2016 23:21, William Brown wrote:

On Fri, 2016-06-10 at 12:57 +0200, Martin Basti wrote: > On 10.06.2016 07:21, William Brown wrote: >> https://fedorahosted.org/389/ticket/48878 >> >> https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... >> >> https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-pe... >> >> >> >> -- >> 389-devel mailing list >> 389-devel(a)lists.fedoraproject.org >> https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject... > Hello, some notes if I can :) > > 1) > This change is harder to read with PEP8 > - topology.standalone.backends.create(None, > - properties={ > - BACKEND_NAME: NEW_BACKEND_1, > - 'suffix':NEW_SUFFIX_1, > - }) > + topology.standalone.backends.create(None, properties={ > + BACKEND_NAME: NEW_BACKEND_1, > + 'suffix': NEW_SUFFIX_1, > + }) > ents = topology.standalone.backends.list() > for ent in ents: > topology.standalone.log.info("List(%d): backend %s" % > > I suggest to use > topology.standalone.backends.create( > None, properties={ > BACKEND_NAME: NEW_BACKEND_1, > 'suffix': NEW_SUFFIX_1, > }) > > Same for NEW_BACKEND_2 Done! https://fedorahosted.org/389/attachment/ticket/48878/0001-Ticket-48878-be... > 2) > I'm not sure if change in python-lib389.spec belongs to PEP8 related > patch or if it is related to PEP8 > > Otherwise LGTM for PEP8 fixes :) > The idea was that basically this is a "house keeping" ticket to get ready for release. That's why I put them there. -- 389-devel mailing list 389-devel(a)lists.fedoraproject.org https://lists.fedoraproject.org/admin/lists/389-devel@lists.fedoraproject...

LGTM or ACK if I'm allowed to ACKing patches here :) Martin Basti @ IPA

Reply

2874

days inactive

2878

days old

389-devel@lists.fedoraproject.org

Manage subscription

3 comments

2 participants

tags (0)

participants (2)

Martin Basti
William Brown