On 02/16/2011 09:50 AM, Chris Lalancette wrote:
On 02/16/11 - 09:37:04AM, Mike Orazi wrote:
> ---
> .../deltacloud_recipe/manifests/image-factory.pp | 7 +------
> 1 files changed, 1 insertions(+), 6 deletions(-)
>
> diff --git a/recipes/deltacloud_recipe/manifests/image-factory.pp
b/recipes/deltacloud_recipe/manifests/image-factory.pp
> index 6d4be23..c937f66 100644
> --- a/recipes/deltacloud_recipe/manifests/image-factory.pp
> +++ b/recipes/deltacloud_recipe/manifests/image-factory.pp
> @@ -4,14 +4,9 @@ class deltacloud::image-factory inherits deltacloud {
> # TODO: Fix me, find a better way to do this...
> # We need to also install this rpm from amazon
> if $enable_packages {
> - package{"ec2-ami-tools":
> - provider => "rpm",
> - source =>
"http://s3.amazonaws.com/ec2-downloads/ec2-ami-tools.noarch.rpm",
> - ensure => 'installed' }
> -
> package { 'rubygem-deltacloud-image-builder-agent':
> provider => 'yum', ensure =>
'installed',
> - require => [Package['ec2-ami-tools'],
Yumrepo['deltacloud_arch', 'deltacloud_noarch']]}
> + require => [Yumrepo['deltacloud_arch',
'deltacloud_noarch']]}
> }
Looks good, but do we also need to remove it from the "uninstall" section
below?
Good catch. It will work as written, but I'd rather clean it up all the
we and retest it. I'll send the amended patch back to list.
Thanks,
Mike